feat(core-api): add SocketIoConnectionPathV1 constant to OpenAPI specs #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
force-pushed
the
feat-core-api-socket-io-connection-path
branch
from
227c81d
to
c154957
Compare
kikoncuo
approved these changes
May 6, 2021
takeutak
approved these changes
May 10, 2021
petermetz
force-pushed
the
feat-core-api-socket-io-connection-path
branch
2 times, most recently
from
218b3f8
to
a9356cf
Compare
This defines a constant in the OpenAPI specification so that it can be reused everywhere else in the code, including in the generated documentation that we intend to create from the OpenAPI specifications later on and also other packages in the Typescript code who import the core-api package. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
feat-core-api-socket-io-connection-path
branch
from
a9356cf
to
87c4497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines a constant in the OpenAPI specification so that it can be
reused everywhere else in the code, including in the generated
documentation that we intend to create from the OpenAPI specifications
later on and also other packages in the Typescript code who import the
core-api package.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Related to #297