test: fix PKI magic strings in besu tests - genesis account #1104
Labels
Developer_Experience
good-first-issue
Good for newcomers
good-first-issue-100-introductory
Hacktoberfest
Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Comments
petermetz
added
good-first-issue
|
I'm going to work on this 👍🏼 |
awadhana
added a commit
to awadhana/cactus
that referenced
this issue
Jul 6, 2021
Fixes hyperledger#1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
Merged
awadhana
added a commit
to awadhana/cactus
that referenced
this issue
Jul 6, 2021
Fixes hyperledger#1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
awadhana
added a commit
to awadhana/cactus
that referenced
this issue
Jul 8, 2021
…e previously causing linter issues. Fixes hyperledger#1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
awadhana
added a commit
to awadhana/cactus
that referenced
this issue
Jul 8, 2021
…e previously causing linter issues. Fixes hyperledger#1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
awadhana
added a commit
to awadhana/cactus
that referenced
this issue
Jul 8, 2021
and linter warnings Fixes hyperledger#1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
petermetz
pushed a commit
that referenced
this issue
Jul 11, 2021
and linter warnings Fixes #1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
RafaelAPB
pushed a commit
to RafaelAPB/blockchain-integration-framework
that referenced
this issue
Mar 9, 2022
and linter warnings Fixes hyperledger#1104 Signed-off-by: Hana Awad <awadhana0825@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
We have dozens of test cases where the the default besu genesis accounts are hardcoded in magic strings.
The
BesuTestLedgerclass has methods retrieving the same values and therefore we should migrate the tests over to use those instead of the magic strings.What it boils down to is applying this change in all the other test cases where the private/public key pair of the high net worth genesis account appears in magic strings.
The change (example): #1102 (comment)
Acceptance Criteria
627306090abaB3A6e1400e9345bC60c78a8BEf57orc87509a1c067bbde78beb793e6fa76530b6382a4c0241e5e4a9ec0a0f44dc0d3in the entire project, there are no test cases where I see it. It only appears inside the besu test ledger class.cc: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone
The text was updated successfully, but these errors were encountered: