New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-server): Invoke onPluginInit() on every connector during instantiation #1444

Closed

m-courtin opened this issue Oct 7, 2021 · 0 comments · Fixed by #1446

Labels

Contributor

m-courtin commented Oct 7, 2021

Describe the bug

In the latest Cactus version the onPluginInit() functionality required by ICactusPlugin Interface is nowhere invoked / called. So the onPluginInit() functionality is never executed.

Expected behavior

The onPluginInit() needs to be invoked for each connector in api-server at the end of the instantiatePlugin function.

m-courtin added the bug label

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

c06cf00

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin mentioned this issue

fix(api-server): fixes issue 1444 invoking the required onPluginInit #1446

Merged

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

12892ce

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

petermetz added the API_Server label

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

78a8ea3

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

1cd763a

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fix issue 1444 enhancement with specific error-handling

853e516

Separate error handling for the onPluginInit execution within
instantiatePlugin

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

5629c48

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fix issue 1444 enhancement with specific error-handling

44dd885

Separate error handling for the onPluginInit execution within
instantiatePlugin

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

d4a1cae

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fix issue 1444 enhancement with specific error-handling

7413a54

Separate error handling for the onPluginInit execution within
instantiatePlugin

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

61f27b2

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fix issue 1444 enhancement with specific error-handling

d7d5bae

Separate error handling for the onPluginInit execution within
instantiatePlugin

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

8c87107

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fix issue 1444 enhancement with specific error-handling

5017ab8

Separate error handling for the onPluginInit execution within
instantiatePlugin

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

m-courtin added a commit to m-courtin/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

a3ffc80

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

petermetz closed this as completed in #1446

petermetz pushed a commit that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

0b4dc2e

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: #1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

brioux pushed a commit to brioux/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

9955f61

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

bdbcea3

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue


          fix: fixes issue 1444 invoking the onPluginInit

2c777f7

In api server the instantiatePlugin function is now calling the required
onPluginInit for each corresponding connector

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment