Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): sibling package dependencies keychain-memory 0.6.0 #1532

Closed
petermetz opened this issue Nov 11, 2021 · 0 comments · Fixed by #1533
Closed

fix(deps): sibling package dependencies keychain-memory 0.6.0 #1532

petermetz opened this issue Nov 11, 2021 · 0 comments · Fixed by #1533
Assignees
@petermetz
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@petermetz
Copy link
Contributor

Describe the bug

We have an outdated dependency on one of our own packages. Usually lerna auto-updates them at release creation time but this one might've been skipped due to a bug or someone accidentally committed it after a difficult rebase and the reviewers missed it.

To Reproduce

Do a search for "0.6.0"

Expected behavior

All the sibling package dependencies should be locked down to the current release which at the moment of this writing is 1.0.0-rc.2

Screenshots

Screenshot from 2021-11-11 11-45-11.png

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

1.0.0-rc.2

Additional context

This was discovered during work done on the jest migration co-existence branch.
@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 11, 2021
@petermetz petermetz self-assigned this Nov 11, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Nov 11, 2021
@petermetz
fix(deps): sibling package dependencies keychain-memory 0.6.0 hyperle…
4c798f2 
…dger-cacti#1532

This might be the cause of some very strange errors that the configure
script has been experiencing lately (also might be a completely benign
bug but we'll see, it needed to be fixed either way).

As a follow-up to this an automated check should be made in the CI which
verifies every dependency declaration in all package.json files to be
referring to the latest and greatest version when pulling in sibling
packages as dependencies.

Fixes hyperledger-cacti#1532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Nov 11, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Nov 12, 2021
@petermetz
fix(deps): sibling package dependencies keychain-memory 0.6.0 hyperle…
bde3698 
…dger-cacti#1532

This might be the cause of some very strange errors that the configure
script has been experiencing lately (also might be a completely benign
bug but we'll see, it needed to be fixed either way).

As a follow-up to this an automated check should be made in the CI which
verifies every dependency declaration in all package.json files to be
referring to the latest and greatest version when pulling in sibling
packages as dependencies.

Fixes hyperledger-cacti#1532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Nov 12, 2021
@petermetz
fix(deps): sibling package dependencies keychain-memory 0.6.0 #1532
d01d72d 
This might be the cause of some very strange errors that the configure
script has been experiencing lately (also might be a completely benign
bug but we'll see, it needed to be fixed either way).

As a follow-up to this an automated check should be made in the CI which
verifies every dependency declaration in all package.json files to be
referring to the latest and greatest version when pulling in sibling
packages as dependencies.

Fixes #1532

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): sibling package dependencies keychain-memory 0.6.0 #1532 petermetz/cacti
1 participant
@petermetz