Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-api): add weaver protobuf codegen #1556

Closed
petermetz opened this issue Nov 23, 2021 · 0 comments · Fixed by #1759
Closed

feat(core-api): add weaver protobuf codegen #1556

petermetz opened this issue Nov 23, 2021 · 0 comments · Fixed by #1759
Assignees
@petermetz
Labels
Core_API Changes related to the Core API Package dependencies Pull requests that update a dependency file enhancement New feature or request P1 Priority 1: Highest Weaver Tasks related to the future of Cactus & Weaver together.

Comments

@petermetz
Copy link
Member

petermetz commented Nov 23, 2021 •
edited

#1523 (comment)

VRamakrishna commented
@petermetz I think we should import the compiled versions (i.e., language-specific bindings) too. Presently, Weaver has these for JS, Go, and Java. Rust is being worked on.
@petermetz petermetz added Core_API Changes related to the Core API Package dependencies Pull requests that update a dependency file enhancement New feature or request P1 Priority 1: Highest Weaver Tasks related to the future of Cactus & Weaver together. labels Nov 23, 2021
@petermetz petermetz self-assigned this Nov 23, 2021
@petermetz petermetz mentioned this issue Nov 23, 2021
Closed
petermetz added a commit to petermetz/cacti that referenced this issue Jan 11, 2022
@petermetz
feat(core-api): add weaver protobuf codegen hyperledger#1556
287abee 
Rust code now gets generated from the Weaver protocol buffer definitions
Next step is to have the automated publishing set up.

Fixes hyperledger#1556

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jan 11, 2022
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Jan 12, 2022
@petermetz
feat(core-api): add weaver protobuf codegen hyperledger#1556
a5520fd 
Rust code now gets generated from the Weaver protocol buffer definitions
Next step is to have the automated publishing set up.

To test the rust build, you need to run either one of the following:

`yarn lerna run proto:protoc-gen-rust` (from the project root)

or a regular cargo build from the core-api package directory, e.g.:

```sh
cd packages/cactus-core-api/
cargo build
```

Fixes hyperledger#1556

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jan 18, 2022
@petermetz
feat(core-api): add weaver protobuf codegen hyperledger#1556
49dc56f 
Rust code now gets generated from the Weaver protocol buffer definitions
Next step is to have the automated publishing set up.

To test the rust build, you need to run either one of the following:

`yarn lerna run proto:protoc-gen-rust` (from the project root)

or a regular cargo build from the core-api package directory, e.g.:

```sh
cd packages/cactus-core-api/
cargo build
```

Fixes hyperledger#1556

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jan 18, 2022
@petermetz
feat(core-api): add weaver protobuf codegen hyperledger#1556
794207a 
Rust code now gets generated from the Weaver protocol buffer definitions
Next step is to have the automated publishing set up.

To test the rust build, you need to run either one of the following:

`yarn lerna run proto:protoc-gen-rust` (from the project root)

or a regular cargo build from the core-api package directory, e.g.:

```sh
cd packages/cactus-core-api/
cargo build
```

Fixes hyperledger#1556

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jan 18, 2022
@petermetz
docs(cactus-core-api): add README file
af13fb5 
Depends on hyperledger#1556 - feat(core-api): add weaver protobuf codegen

Fixes hyperledger#833

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jan 18, 2022
@petermetz
docs(cactus-core-api): add README file
6fe0bdf 
Depends on hyperledger#1556 - feat(core-api): add weaver protobuf codegen

Fixes hyperledger#833

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jan 18, 2022
Merged
petermetz added a commit that referenced this issue Jan 21, 2022
@petermetz
feat(core-api): add weaver protobuf codegen #1556
b5b68a7 
Rust code now gets generated from the Weaver protocol buffer definitions
Next step is to have the automated publishing set up.

To test the rust build, you need to run either one of the following:

`yarn lerna run proto:protoc-gen-rust` (from the project root)

or a regular cargo build from the core-api package directory, e.g.:

```sh
cd packages/cactus-core-api/
cargo build
```

Fixes #1556

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Jan 23, 2022
@petermetz
docs(cactus-core-api): add README file
9e85939 
Depends on #1556 - feat(core-api): add weaver protobuf codegen

Fixes #833

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Core_API Changes related to the Core API Package dependencies Pull requests that update a dependency file enhancement New feature or request P1 Priority 1: Highest Weaver Tasks related to the future of Cactus & Weaver together.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core-api): add weaver protobuf codegen #1556 petermetz/cacti
1 participant
@petermetz