Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-api): add weaver protocol buffer definitions #1523

Closed
petermetz opened this issue Nov 9, 2021 · 3 comments · Fixed by #1544
Closed

feat(core-api): add weaver protocol buffer definitions #1523

petermetz opened this issue Nov 9, 2021 · 3 comments · Fixed by #1544
Assignees
@petermetz
Labels
API_Server Core_API Changes related to the Core API Package P1 Priority 1: Highest Weaver Tasks related to the future of Cactus & Weaver together.

Comments

@petermetz
Copy link
Contributor

petermetz commented Nov 9, 2021 •
edited
Loading

Acceptance Criteria

  1. Commit the protocol buffer definitions of Weaver to the Cactus Core API package
  2. Set up automatic publishing of a Rust crate so that any time a commit is merged to main a new version of the crate is pushed with the protocol buffer definitions - this step is dependent on whether we want to also publish the generated Rust code for the protocol buffers or just the .proto files. If the latter then there's no need to set up the crate publishing just yet
  3. Ensure Rama has signed off on adding the files (verbal sign-off has been acquired but also on the git commit log)
  4. Ensure Typescript definitions are generated from the .proto files - figure out if this should be in it's own package or in one of the existing ones such as core or cmd-api-server etc.
@petermetz petermetz added API_Server Core_API Changes related to the Core API Package P1 Priority 1: Highest Weaver Tasks related to the future of Cactus & Weaver together. labels Nov 9, 2021
@petermetz petermetz self-assigned this Nov 9, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Nov 9, 2021
@petermetz
feat(core-api): add weaver protocol buffer definitions hyperledger-ca…
b79d952 
…cti#1523

Adding the .proto definitions from here as discussed earlier with @VRamakrishna

To-do: I skipped the fabric driver proto due to an error on account of the
Fabric peer definitions not being present (unresolved import error).

Fixes hyperledger-cacti#1523

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Nov 16, 2021
@petermetz
feat(core-api): add weaver protocol buffer definitions hyperledger-ca…
e462428 
…cti#1523

Adding the .proto definitions from here as discussed earlier with @VRamakrishna

To-do: I skipped the fabric driver proto due to an error on account of the
Fabric peer definitions not being present (unresolved import error).

Fixes hyperledger-cacti#1523

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
VRamakrishna added a commit to petermetz/cacti that referenced this issue Nov 17, 2021
@VRamakrishna
Updated Weaver protos README and imported latest schema additions
3a5f18d 
Fixes hyperledger-cacti#1523

Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
@VRamakrishna VRamakrishna mentioned this issue Nov 17, 2021
Closed
@VRamakrishna
Copy link
Contributor

@petermetz Submitted a PR to your branch: petermetz#8.

@VRamakrishna
Copy link
Contributor

@petermetz I think we should import the compiled versions (i.e., language-specific bindings) too. Presently, Weaver has these for JS, Go, and Java. Rust is being worked on.

petermetz added a commit to petermetz/cacti that referenced this issue Nov 17, 2021
@petermetz
feat(core-api): add weaver protocol buffer definitions hyperledger-ca…
1f6aa64 
…cti#1523

Adding the .proto definitions from here as discussed earlier with @VRamakrishna

To-do: I skipped the fabric driver proto due to an error on account of the
Fabric peer definitions not being present (unresolved import error).

Fixes hyperledger-cacti#1523

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to petermetz/cacti that referenced this issue Nov 17, 2021
@VRamakrishna @petermetz
refactor(core-api): updated weaver protocol buffer definitions hyperl…
7ca45d0 
…edger-cacti#1523

Updated Weaver protos README and imported latest schema additions

Fixes hyperledger-cacti#1523

Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
@petermetz petermetz mentioned this issue Nov 17, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Nov 17, 2021
@petermetz
feat(core-api): add weaver protocol buffer definitions hyperledger-ca…
716b804 
…cti#1523

Adding the .proto definitions from here as discussed earlier with @VRamakrishna

To-do: I skipped the fabric driver proto due to an error on account of the
Fabric peer definitions not being present (unresolved import error).

Fixes hyperledger-cacti#1523

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit to petermetz/cacti that referenced this issue Nov 17, 2021
@VRamakrishna @petermetz
refactor(core-api): updated weaver protocol buffer definitions hyperl…
2949140 
…edger-cacti#1523

Updated Weaver protos README and imported latest schema additions

Fixes hyperledger-cacti#1523

Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
@petermetz petermetz mentioned this issue Nov 23, 2021
Closed
@petermetz
Copy link
Contributor Author

@petermetz I think we should import the compiled versions (i.e., language-specific bindings) too. Presently, Weaver has these for JS, Go, and Java. Rust is being worked on.

@VRamakrishna Agreed, 100%, I added a new issue to the epic => #1556

petermetz added a commit that referenced this issue Nov 24, 2021
@petermetz
feat(core-api): add weaver protocol buffer definitions #1523
851c071 
Adding the .proto definitions from here as discussed earlier with @VRamakrishna

To-do: I skipped the fabric driver proto due to an error on account of the
Fabric peer definitions not being present (unresolved import error).

Fixes #1523

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Nov 24, 2021
@VRamakrishna @petermetz
refactor(core-api): updated weaver protocol buffer definitions #1523
e0e322c 
Updated Weaver protos README and imported latest schema additions

Fixes #1523

Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Nov 25, 2021
@VRamakrishna @Leeyoungone
refactor(core-api): updated weaver protocol buffer definitions hyperl…
4667566 
…edger-cacti#1523

Updated Weaver protos README and imported latest schema additions

Fixes hyperledger-cacti#1523

Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Dec 3, 2021
@VRamakrishna @Leeyoungone
refactor(core-api): updated weaver protocol buffer definitions hyperl…
722933f 
…edger-cacti#1523

Updated Weaver protos README and imported latest schema additions

Fixes hyperledger-cacti#1523

Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
API_Server Core_API Changes related to the Core API Package P1 Priority 1: Highest Weaver Tasks related to the future of Cactus & Weaver together.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core-api): add weaver protocol buffer definitions #1523 petermetz/cacti
2 participants
@petermetz @VRamakrishna