Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): Checks and CodedError classes #275

Conversation

petermetz
Copy link
Contributor

Utilities for easier one-liners that can verify arguments or
execution state in a much more concise way compared to
if conditions throwing manually. Makes the code less verbose
and requires less typing as well.

Also: added a bools utlity class for checking strict boolean
typing of a value and a new string utility method as well.

Fixes #266

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Utilities for easier one-liners that can verify arguments or
execution state in a much more concise way compared to
if conditions throwing manually. Makes the code less verbose
and requires less typing as well.

Also: added a bools utlity class for checking strict boolean
typing of a value and a new string utility method as well.

Fixes hyperledger-cacti#266

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz added enhancement New feature or request dependencies Pull requests that update a dependency file Developer_Experience labels Sep 5, 2020
petermetz added a commit to petermetz/cacti that referenced this pull request Sep 5, 2020
Helpers to list files under an arbitrary path in a container's file
system and a more generic method that helps executing shell
commands (exec())

Depends on hyperledger-cacti#275

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this pull request Sep 5, 2020
Also fixes the issues in the fabric all in one image
with file path typos, docker sock mounting, etc.

Fixes hyperledger-cacti#252

Depends on hyperledger-cacti#275
Depends on hyperledger-cacti#276
Depends on hyperledger-cacti#277

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@takeutak takeutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit c65baf8 into hyperledger-cacti:master Sep 11, 2020
@petermetz petermetz deleted the feat/common/preconditions-coded-errors-266 branch September 11, 2020 20:14
petermetz added a commit to petermetz/cacti that referenced this pull request Sep 18, 2020
Helpers to list files under an arbitrary path in a container's file
system and a more generic method that helps executing shell
commands (exec())

Depends on hyperledger-cacti#275

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this pull request Sep 18, 2020
Also fixes the issues in the fabric all in one image
with file path typos, docker sock mounting, etc.

Fixes hyperledger-cacti#252

Depends on hyperledger-cacti#275
Depends on hyperledger-cacti#276
Depends on hyperledger-cacti#277

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this pull request Sep 25, 2020
Helpers to list files under an arbitrary path in a container's file
system and a more generic method that helps executing shell
commands (exec())

Depends on hyperledger-cacti#275

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this pull request Oct 1, 2020
Helpers to list files under an arbitrary path in a container's file
system and a more generic method that helps executing shell
commands (exec())

Depends on #275

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this pull request Oct 1, 2020
Also fixes the issues in the fabric all in one image
with file path typos, docker sock mounting, etc.

Fixes hyperledger-cacti#252

Depends on hyperledger-cacti#275
Depends on hyperledger-cacti#276
Depends on hyperledger-cacti#277

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this pull request Oct 2, 2020
Also fixes the issues in the fabric all in one image
with file path typos, docker sock mounting, etc.

Fixes hyperledger-cacti#252

Depends on hyperledger-cacti#275
Depends on hyperledger-cacti#276
Depends on hyperledger-cacti#277

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this pull request Oct 6, 2020
Also fixes the issues in the fabric all in one image
with file path typos, docker sock mounting, etc.

Fixes hyperledger-cacti#252

Depends on hyperledger-cacti#275
Depends on hyperledger-cacti#276
Depends on hyperledger-cacti#277

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this pull request Oct 7, 2020
Also fixes the issues in the fabric all in one image
with file path typos, docker sock mounting, etc.

Fixes hyperledger-cacti#252

Depends on hyperledger-cacti#275
Depends on hyperledger-cacti#276
Depends on hyperledger-cacti#277

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this pull request Oct 7, 2020
Also fixes the issues in the fabric all in one image
with file path typos, docker sock mounting, etc.

Fixes #252

Depends on #275
Depends on #276
Depends on #277

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Developer_Experience enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(common): preconditions utility with coded errors
3 participants