Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): servers#listen() port validation #491

Closed
petermetz opened this issue Jan 14, 2021 · 0 comments · Fixed by #492
Closed

fix(common): servers#listen() port validation #491

petermetz opened this issue Jan 14, 2021 · 0 comments · Fixed by #492
Labels
bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Milestone
v0.4.0

Comments

@petermetz
Copy link
Member

Describe the bug

The Servers.listen(...) method needs to ensure that the provided port parameter is a positive finite integer within the approved range for TCP ports.

cc: @sfuji822 @takeutak @hartm @jonathan-m-hamilton
@petermetz petermetz added bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Jan 14, 2021
@petermetz petermetz added this to the v0.4.0 milestone Jan 14, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Jan 14, 2021
@petermetz
fix(common): servers.listen() port validation
1254131 
Adds more type assertions to check if the
provided port number is indeed a finite,
positive integer.

Fixes hyperledger#491

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
(cherry picked from commit 3b16aeb)
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jan 14, 2021
Merged
petermetz added a commit that referenced this issue Jan 15, 2021
@petermetz
fix(common): servers.listen() port validation
cd50124 
Adds more type assertions to check if the
provided port number is indeed a finite,
positive integer.

Fixes #491

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
(cherry picked from commit 3b16aeb)
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

fix(common): servers.listen() port validation petermetz/cacti
1 participant
@petermetz