Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): package.json publish config non-public #753

Closed
petermetz opened this issue Mar 30, 2021 · 0 comments · Fixed by #754
Closed

fix(release): package.json publish config non-public #753

petermetz opened this issue Mar 30, 2021 · 0 comments · Fixed by #754
Assignees
@petermetz
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@petermetz
Copy link
Contributor

Describe the bug

Several packages are missing the publish configuration from their package.json files which made them private packages on npm by default.
I fixed the visibility manually via npm GUI but we still need to update the package.json files to match that in version control as well.

To Reproduce

N/A

Expected behavior

N/A

Logs/Stack traces

N/A

Screenshots

N/A

Cloud provider or hardware configuration:

N/A

Operating system name, version, build:

N/A

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

N/A

Hyperledger Cactus Plugins/Connectors Used

N/A

Additional context

N/A

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan
@petermetz petermetz added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 30, 2021
@petermetz petermetz self-assigned this Mar 30, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Mar 30, 2021
@petermetz
fix(release): package.json publish config non-public hyperledger-cact…
f96e1de 
…i#753

Several packages were missing the publish configuration
from their package.json files which made them private
packages on npm by default.
I fixed the visibility manually via npm GUI but we still need
to update the package.json files to match that in version
control as well so here we go.

Fixes hyperledger-cacti#753

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Mar 30, 2021
Merged
petermetz added a commit that referenced this issue Apr 1, 2021
@petermetz
fix(release): package.json publish config non-public #753
5a1b7a6 
Several packages were missing the publish configuration
from their package.json files which made them private
packages on npm by default.
I fixed the visibility manually via npm GUI but we still need
to update the package.json files to match that in version
control as well so here we go.

Fixes #753

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(release): package.json publish config non-public #753 petermetz/cacti
1 participant
@petermetz