Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector-quorum): contract constructor arguments #962

Closed
petermetz opened this issue May 12, 2021 · 0 comments · Fixed by #1447
Closed

feat(connector-quorum): contract constructor arguments #962

petermetz opened this issue May 12, 2021 · 0 comments · Fixed by #1447
Assignees
@travis-payne
Labels
enhancement New feature or request Quorum
Milestone
v0.10.0

Comments

@petermetz
Copy link
Contributor

petermetz commented May 12, 2021 •
edited
Loading

Description

As a user of Cactus I want to be able to specify constructor args for contracts I'm deploying so that it is possible for me to deploy contracts that have constructor arguments defined for them.

Besu and Xdai has support for this already so this would be largely just porting that change to the Quorum connector as well.

https://chat.hyperledger.org/channel/cactus?msg=WgTabjQho3oFGskSa

Acceptance Criteria

  1. Test coverage
  2. CI passing
  3. Do not deviate from how it's done in the other 2 mentioned connectors unless it is for a specific reason.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy @jagpreetsinghsasan @TonyRowntree @travis-payne
@petermetz petermetz added enhancement New feature or request Quorum labels May 12, 2021
@petermetz petermetz added this to the v0.6.0 milestone May 12, 2021
@petermetz petermetz modified the milestones: v0.6.0, v0.7.0 Jul 20, 2021
@petermetz petermetz modified the milestones: v0.7.0, v0.8.0 Aug 10, 2021
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Sep 2, 2021
@travis-payne travis-payne self-assigned this Sep 28, 2021
@petermetz petermetz mentioned this issue Sep 30, 2021
Closed
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Oct 7, 2021
feat: allows for constructor args in quorum contract deploy
41d914a 
Closes: hyperledger-cacti#962
Signed-off-by: Travis Payne <travis.payne@accenture.com>
@travis-payne travis-payne mentioned this issue Oct 7, 2021
Merged
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Oct 15, 2021
feat: allows for constructor args in quorum contract deploy
2d58205 
Closes: hyperledger-cacti#962
Signed-off-by: Travis Payne <travis.payne@accenture.com>
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Oct 15, 2021
feat: allows for constructor args in quorum contract deploy
80261f8 
Closes: hyperledger-cacti#962
Signed-off-by: Travis Payne <travis.payne@accenture.com>
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Oct 22, 2021
feat: allows for constructor args in quorum contract deploy
4ceeb64 
Closes: hyperledger-cacti#962
Signed-off-by: Travis Payne <travis.payne@accenture.com>
petermetz pushed a commit that referenced this issue Oct 23, 2021
@petermetz
feat: allows for constructor args in quorum contract deploy
cb3c8d8 
Closes: #962
Signed-off-by: Travis Payne <travis.payne@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Oct 26, 2021
@Leeyoungone
feat: allows for constructor args in quorum contract deploy
abeee68 
Closes: hyperledger-cacti#962
Signed-off-by: Travis Payne <travis.payne@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@RafaelAPB
feat: allows for constructor args in quorum contract deploy
ec0beb7 
Closes: hyperledger-cacti#962
Signed-off-by: Travis Payne <travis.payne@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis-payne travis-payne

Labels
enhancement New feature or request Quorum
Projects
None yet
Milestone
v0.10.0
2 participants
@petermetz @travis-payne