Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd-api-server): enable version selection in plugins #1390

Conversation

elenaizaguirre
Copy link
Contributor

cactus-cmd-api-server can now import plugins specifying
the npm package version as a plugin option

cmd-api-server: add missing dependency bluebird

closes #839 and #840

Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com

@elenaizaguirre
Copy link
Contributor Author

@petermetz Finally I added bluebird dependency in this PR instead of the Quorum one because I thought it was better join cmd-api-server changes

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #1390 (cbe857f) into main (9c7bab5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   71.34%   71.33%   -0.02%     
==========================================
  Files         308      308              
  Lines       11262    11264       +2     
  Branches     1382     1383       +1     
==========================================
  Hits         8035     8035              
- Misses       2473     2475       +2     
  Partials      754      754              
Impacted Files Coverage Δ
...s-cmd-api-server/src/main/typescript/api-server.ts 86.28% <100.00%> (+0.08%) ⬆️
...main/typescript/rustc-container/rustc-container.ts 66.29% <0.00%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7bab5...cbe857f. Read the comment docs.

@elenaizaguirre elenaizaguirre force-pushed the fix-api-server-import-plugins-version branch from d5855a6 to da27bd2 Compare October 4, 2021 11:20
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elenaizaguirre Reminder to hit 're-request review' when you want it to be reviewed again.
Marking the comments as 'resolved' doesn't do the same (I agree that it probably should though)

@elenaizaguirre
Copy link
Contributor Author

@elenaizaguirre Reminder to hit 're-request review' when you want it to be reviewed again. Marking the comments as 'resolved' doesn't do the same (I agree that it probably should though)

I'll keep it in mind!

@elenaizaguirre elenaizaguirre force-pushed the fix-api-server-import-plugins-version branch 2 times, most recently from 798ce3f to ecbada4 Compare October 5, 2021 10:56
cactus-cmd-api-server can now import plugins specifying
the npm package version as a plugin option

cmd-api-server: add missing dependency bluebird

closes hyperledger-cacti#839 and hyperledger-cacti#840

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
@elenaizaguirre elenaizaguirre force-pushed the fix-api-server-import-plugins-version branch from ecbada4 to 1b8765c Compare October 5, 2021 14:42
@petermetz petermetz merged commit b982777 into hyperledger-cacti:main Oct 6, 2021
@petermetz petermetz deleted the fix-api-server-import-plugins-version branch October 6, 2021 05:14
@elenaizaguirre
Copy link
Contributor Author

@petermetz This PR closes two issues but only one of them is closed now. Should I change the way to reference them?

@petermetz
Copy link
Contributor

@elenaizaguirre I think the second one you'll have to close manually now that the PR has been merged in the meantime.
For the future: Yes please, however many issues are being closed by a PR, link all of them to it, it's fine if sometimes we accidentally open issues that end up being duplicates like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(keychain-memory): Cannot find module "uuid"
4 participants