-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmd-api-server): enable version selection in plugins #1390
fix(cmd-api-server): enable version selection in plugins #1390
Conversation
@petermetz Finally I added bluebird dependency in this PR instead of the Quorum one because I thought it was better join cmd-api-server changes |
packages/cactus-cmd-api-server/src/main/typescript/api-server.ts
Outdated
Show resolved
Hide resolved
...s-test-cmd-api-server/src/test/typescript/integration/plugin-import-with-npm-install.test.ts
Outdated
Show resolved
Hide resolved
6bced8d
to
d5855a6
Compare
Codecov Report
@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
- Coverage 71.34% 71.33% -0.02%
==========================================
Files 308 308
Lines 11262 11264 +2
Branches 1382 1383 +1
==========================================
Hits 8035 8035
- Misses 2473 2475 +2
Partials 754 754
Continue to review full report at Codecov.
|
d5855a6
to
da27bd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elenaizaguirre Reminder to hit 're-request review' when you want it to be reviewed again.
Marking the comments as 'resolved' doesn't do the same (I agree that it probably should though)
I'll keep it in mind! |
798ce3f
to
ecbada4
Compare
cactus-cmd-api-server can now import plugins specifying the npm package version as a plugin option cmd-api-server: add missing dependency bluebird closes hyperledger-cacti#839 and hyperledger-cacti#840 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
ecbada4
to
1b8765c
Compare
@petermetz This PR closes two issues but only one of them is closed now. Should I change the way to reference them? |
@elenaizaguirre I think the second one you'll have to close manually now that the PR has been merged in the meantime. |
cactus-cmd-api-server can now import plugins specifying
the npm package version as a plugin option
cmd-api-server: add missing dependency bluebird
closes #839 and #840
Signed-off-by: Elena Izaguirre e.izaguirre.equiza@accenture.com