Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #536 Update error messages for 'caliper-cli' package #1348

Merged
merged 5 commits into from
May 27, 2022

Conversation

0xt3j4s
Copy link
Contributor

@0xt3j4s 0xt3j4s commented May 17, 2022

Signed-off-by: Tezas-6174 <jamdade.2@iitj.ac.in>
Signed-off-by: Tezas-6174 <jamdade.2@iitj.ac.in>
Signed-off-by: Tezas-6174 <jamdade.2@iitj.ac.in>
Signed-off-by: Tezas-6174 <jamdade.2@iitj.ac.in>
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment from me

Signed-off-by: Tezas-6174 <jamdade.2@iitj.ac.in>
@0xt3j4s 0xt3j4s requested a review from davidkel May 21, 2022 14:31
@davidkel
Copy link
Contributor

this change can't be merged until #1352 is merged

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit 0c1e973 into hyperledger-caliper:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make logging consistent
2 participants