-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new org to the channel #490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf51015
to
38ebf42
Compare
4a9eaec
to
e2071e5
Compare
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
* [#issue-487]Modify the request to create a node 1. Change the quantity parameter to a number 2. The action parameter is passed through the message body Signed-off-by: fengyang_sy <fengyang.09186@h3c.com> * Update node.js * Update index.js * Update index.js * Update node.js * Update index.js * Update index.js Signed-off-by: fengyang_sy <fengyang.09186@h3c.com> Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Implement the API allowing a peer to join a channel through the command `peer channel join -b ${APP_CHANNEL}.block`. Signed-off-by: Xichen Pan <xichen.pan@gmail.com> Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
9f34205
to
dd0aef1
Compare
yeasy
reviewed
Sep 24, 2022
yeasy
reviewed
Sep 24, 2022
"CORE_PEER_MSPCONFIGPATH": "{}/{}/users/Admin@{}/msp".format( | ||
dir_node, org_name, org_name), | ||
# Add new org msp | ||
temp_config = channel.config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some basic json validation.
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
yeasy
reviewed
Oct 13, 2022
dir_node, org_name, org_name), | ||
data = request.FILES["data"] | ||
config = data.config | ||
org = data.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an optional param to specify whether it's Application org (by default) or Orderer org.
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
Signed-off-by: Yuanmao Zhu <yuanmao@ualberta.ca>
yeasy
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to append an MSP config to the channel config. Currently, we upload the MSP data via the request body, and will implement uploading via file format.
Endpoint:
PUT http://127.0.0.1:8080/api/v1/channels/:channel_id
Request body:
need to set
content-type
asmultipart/form-data
org_type has two choices
Application
andOrderer
Signed-off-by: Yuanmao Zhu yuanmao@ualberta.ca