Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector is recreating subscriptions unnecessarily when only the base subscription exists #62

Closed
awrichar opened this issue Apr 1, 2022 · 0 comments
Closed

Connector is recreating subscriptions unnecessarily when only the base subscription exists #62

awrichar opened this issue Apr 1, 2022 · 0 comments

Comments

@awrichar
Copy link
Contributor

awrichar commented Apr 1, 2022

When only the base subscription exists (with a name like tokensERC1155:base), it seems the connector always triggers migration and recreates all subscriptions.

firefly-tokens-erc1155/src/tokens/tokens.service.ts

Line 176 in 80492e9

if (foundEvents.size === 1 && foundEvents.has(BASE_SUBSCRIPTION_NAME)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@awrichar