Remove auto-migration logic for subscriptions #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hyperledger#62 Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
|
Closes #62 |
|
Also for the record - the manual migration process is to bring the connector down, delete its event stream, then bring it back up and wait for it to recreate the event stream (which will contain a single "base" subscription). Then, for each pool on each erc1155 connector, make this manual POST: Note that the protocol ID for this connector will look something like "F1" or "N2". This call should cause 4 additional subscriptions (per pool) to be added to the event stream. |
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
force-pushed
the
subs
branch
3 times, most recently
from
09db60d
to
7b248d4
Compare
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERC1155 connector currently attempts to detect when event subscriptions need to be deleted and recreated
(for instance, because new events are now supported and require new subscriptions). While this can be convenient,
it also has the potential to cause negative side effects if the new subscriptions fail to create.
Remove the auto-migration path and downgrade this situation to a warning log. This means it will require manual
intervention from a user if (in the future) we add features that require subscriptions to be recreated.