Token pools should be able to reactivate themselves

[awrichar]

The token connectors are currently operating under a false assumption that they can delete pool-specific event subscriptions, re-send a "token-pool" event to FireFly, and expect it to reactivate the pools (therefore recreating the subscriptions for that pool).

This does not happen. FireFly only triggers activation in response to a pool creation event if the pool was previously in "unknown" state:

firefly/internal/events/token_pool_created.go

Line 104 in f40ed6e

if err = em.assets.ActivateTokenPool(ctx, existingPool, pool.Event.Info); err != nil {

Need to revisit this dialogue and determine the best way for connectors to recreate event subscriptions in this scenario.

[awrichar]

Note that pools are (re)activated when processing a definition message for a token pool. Replaying the chain of batch pinned messages would result in pools being properly activated.

However, due to a combination of this bug and hyperledger/firefly-tokens-erc1155#62, restarting the token connector can continuously get into this state with subscriptions missing.

[awrichar]

Closing as invalid. For now, auto-migration of token subscriptions will be removed, and manual migration will be supported only by users directly (re)activating the pools with the token connector.