Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Instrumentation #189

Closed
nguyer opened this issue Sep 10, 2021 · 1 comment · Fixed by #321
Closed

Prometheus Instrumentation #189

nguyer opened this issue Sep 10, 2021 · 1 comment · Fixed by #321
Labels
enhancement New feature or request

Comments

@nguyer
Copy link
Contributor

nguyer commented Sep 10, 2021

We want to start building out robust metrics in FireFly for better operations. As a start, we need to create a metrics endpoint that Prometheus can scrape. This should be pretty easy with the HTTP handler built into the Prometheus Go library: https://github.com/prometheus/client_golang.

As a basic demonstration of the new metrics capabilities, we could just add a simple counter for the number of API calls that have been made to the node. Any time an API endpoint is called, it would simply increment a counter.

As a demo of this functionality, it would be great to see the metrics being reported in Prometheus itself. This could simply be a local instance of Prometheus scraping logs from FireFly nodes running locally, set up by the CLI. The FireFly CLI does not need to set up Prometheus.

@onelapahead
Copy link
Contributor

Re-reading this issue now that #321 is merged, and I think hyperledger/firefly-cli#121 will address some of this but we will still need to add some custom metrics for FF to finish the vision of this issue.

@nguyer would you rather re-open this issue or creating a new issue for the custom metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants