Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor crypto wasm #141

Merged
merged 50 commits into from
Feb 14, 2023
Merged

Refactor crypto wasm #141

merged 50 commits into from
Feb 14, 2023

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Jan 23, 2023 •
edited
Loading

All the details are documented in updated READMEs and changesets.

@0x009922
[refactor]: slightly update Rust source code (WIP)
45694ac 
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: enhance TS-wrap around wasm (WIP)
0fcf6f4 
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: build crypto/wasm-pkg-{target}
1c4eb92 
WASMs aren't included due to their size and
because they aren't finalized yet to be tracked
in Git.

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[misc]: update deps
e12a2cf 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[research]: make step forward to rollup
b680b14 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: polish @iroha2/crypto-* pipelines
9b5c3a0 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[fix]: fix crypto interfaces compatibility; test
44bd831 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[refactor]: polish iroha_crypto crate pub interface
b93bbbd 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: introduce .free()-scoping utilities
b2d3071 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[build]: fix CWD preservation
99a8464 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[build]: export default only for web target
f53731a 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[refactor]: change target-* exports, add wasmPkg
ee72e67 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[refactor]: polish Free utils
a8a02ee 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[refactor]: polish the interface
6aecfa6 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[refactor]: chore
d983f2b 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[chores]: change names in the root rollup conf
70b3d7a 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: implement "adopting" in free-scopes
82789a9 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: integrate data model
563e376 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[refactor]: refactor with cargo-clippy & rustfmt
f066529 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: add more or less stable WASMs to git
0aad7eb 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[build]: use single Rollup and Jake configurations
c41ee74 
New rule: if `jake prepare:all` is run, then
`tsc --notEmit` and `vitest run` should run
without any problem

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[fix]: fix all type errors
8b950ad 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[refactor]: remove unused import
a9eb163 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[build]: resolve interface-wrap correctly, fix declarations
efafcb3 
Also drop `esbuild` and `node-resolve` plugins

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[test]: make crypto integration tests pass
dde8018 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[style]: apply lint & formatting
f0a6cc4 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[chore]: use test-{web,node} naming for consistency
3ce7d7f 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: ignore service files in cloned Iroha repo
e4edd02 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[test]: pass all checks
a80fa1a 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[chore]: ignore .idea
f36ce6a 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[docs]: document changes, satisfy TODOs
ddfeeac 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
Merge remote-tracking branch 'hyperledger/iroha2' into refactor-crypt…
2507399 
…o-wasm

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[ci]: omit type-check task during run-all-checks
138d51a 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[misc]: update client's README and fix deps
650cdb0 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922 0x009922 marked this pull request as ready for review February 2, 2023 09:00
@0x009922
[chore]: remove comment
c8edc08 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[chore]: remove comment
3cf7a69 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
outoftardis
outoftardis reviewed Feb 2, 2023
View reviewed changes
packages/crypto/packages/target-web/README.md Outdated Show resolved Hide resolved
packages/crypto/crypto-rs/README.md Outdated Show resolved Hide resolved
packages/crypto/crypto-rs/README.md Outdated Show resolved Hide resolved
packages/crypto/packages/core/README.md Outdated Show resolved Hide resolved
packages/crypto/packages/core/README.md Outdated Show resolved Hide resolved
.changeset/nine-mugs-accept.md Outdated Show resolved Hide resolved
packages/crypto/packages/interface-wrap/README.md Outdated Show resolved Hide resolved
packages/crypto/packages/interface-wrap/README.md Outdated Show resolved Hide resolved
packages/crypto/packages/interface-wrap/README.md Outdated Show resolved Hide resolved
packages/crypto/packages/interface-wrap/README.md Outdated Show resolved Hide resolved
0x009922 and others added 3 commits February 3, 2023 08:17
@0x009922 @outoftardis
Apply suggestions from code review
0b0cecb 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
@0x009922
[docs]: rephrase guard methods explanation
deff924 
hyperledger-iroha#141 (comment)
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[docs]: extend "moves" note
86acd92 
hyperledger-iroha#141 (comment)
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
outoftardis
outoftardis reviewed Feb 3, 2023
View reviewed changes
packages/crypto/crypto-rs/README.md Outdated Show resolved Hide resolved
packages/crypto/crypto-rs/README.md Outdated Show resolved Hide resolved
packages/crypto/crypto-rs/README.md Outdated Show resolved Hide resolved
packages/crypto/crypto-rs/README.md Outdated Show resolved Hide resolved
packages/crypto/crypto-rs/README.md Outdated Show resolved Hide resolved
packages/crypto/packages/util/README.md Outdated Show resolved Hide resolved
packages/crypto/packages/util/README.md Outdated Show resolved Hide resolved
@0x009922 @outoftardis
Apply suggestions from code review
0d17350 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
0x009922 and others added 3 commits February 3, 2023 19:27
@0x009922
[docs]: apply changes from code review
8db440e 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[docs]: apply changes from code review
41dc695 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922 @outoftardis
Update packages/crypto/packages/util/README.md
927efbb 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
outoftardis
outoftardis approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@outoftardis outoftardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs lgtm

@0x009922
[misc]: apply changesets
6c6b121 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[build]: update lockfile
3f0f954 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922 0x009922 merged commit d59fc76 into hyperledger-iroha:iroha2 Feb 14, 2023
@0x009922 0x009922 deleted the refactor-crypto-wasm branch February 14, 2023 02:31
@0x009922 0x009922 mentioned this pull request Feb 27, 2023
Closed
@6r1d 6r1d mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefashkaa stefashkaa stefashkaa approved these changes

@outoftardis outoftardis outoftardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x009922 @stefashkaa @outoftardis