Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iroha schema doesn't take into account serde transparent structures. #1660

Closed
i1i1 opened this issue Dec 1, 2021 · 1 comment
Closed

Iroha schema doesn't take into account serde transparent structures. #1660

i1i1 opened this issue Dec 1, 2021 · 1 comment
Assignees
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST UI Something about the interface

Comments

@i1i1
Copy link

i1i1 commented Dec 1, 2021

There is a bug with both Metadata and EvaluatesTo classes in Iroha python. The schema should expose all necessary info for client API generation.

@i1i1 i1i1 added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries labels Dec 1, 2021
@appetrosyan appetrosyan self-assigned this May 4, 2022
@mversic mversic assigned mversic and unassigned mversic Sep 30, 2022
@appetrosyan appetrosyan added UI Something about the interface and removed Bug Something isn't working labels Oct 11, 2022
@AlexStroke AlexStroke self-assigned this Aug 24, 2023
@AlexStroke
Copy link
Contributor

Upon further investigation, it has been determined that the problem with serde transparent structures in the Iroha Python schema has been addressed manually. Upon further review, we believe that the underlying concerns about the Iroha schema, particularly with the serde transparent structures in Python, can be holistically addressed by the more comprehensive improvements proposed in Issue #3535. The latter issue aims to enhance the clarity and explicitness of the data-model schema, which will, in turn, make it easier for developers to work with the schema and reduce the likelihood of similar problems arising in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST UI Something about the interface
Projects
None yet
Development

No branches or pull requests

5 participants