Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4059: snapshots "mode" #4365

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Mar 13, 2024

Description

Linked issue

Closes #4059, #4296

Benefits

More expected behaviour of snapshots for users?

@0x009922 0x009922 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha labels Mar 13, 2024
@0x009922 0x009922 self-assigned this Mar 13, 2024
Copy link

@BAStos525

core/src/snapshot.rs Outdated Show resolved Hide resolved
config/src/snapshot.rs Outdated Show resolved Hide resolved
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
cli/src/lib.rs Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8273909280

Details

  • 129 of 170 (75.88%) changed or added relevant lines in 7 files are covered.
  • 4072 unchanged lines in 79 files lost coverage.
  • Overall coverage increased (+0.9%) to 57.677%

Changes Missing Coverage Covered Lines Changed/Added Lines %
config/src/snapshot.rs 11 14 78.57%
core/src/kura.rs 2 6 33.33%
cli/src/lib.rs 0 12 0.0%
core/src/snapshot.rs 104 126 82.54%
Files with Coverage Reduction New Missed Lines %
primitives/src/conststr.rs 1 91.14%
ffi/derive/src/convert.rs 1 84.45%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
crypto/src/signature/bls/mod.rs 2 0.0%
data_model/derive/src/has_origin.rs 3 95.16%
config/src/kura.rs 3 80.0%
primitives/src/addr.rs 3 63.82%
schema/derive/src/lib.rs 5 83.25%
config/src/logger.rs 5 72.73%
Totals Coverage Status
Change from base Build 7884695009: 0.9%
Covered Lines: 22603
Relevant Lines: 39189

💛 - Coveralls

@mversic mversic merged commit 8d0157a into hyperledger-iroha:iroha2-dev Mar 14, 2024
13 checks passed
@0x009922 0x009922 deleted the 4059-snapshots-config branch March 14, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants