-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #4059: snapshots "mode" #4365
Merged
mversic
merged 3 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:4059-snapshots-config
Mar 14, 2024
Merged
[feature] #4059: snapshots "mode" #4365
mversic
merged 3 commits into
hyperledger-iroha:iroha2-dev
from
0x009922:4059-snapshots-config
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
added
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
config-changes
Changes in configuration and start up of the Iroha
labels
Mar 13, 2024
0x009922
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
outoftardis,
Erigara,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
March 13, 2024 10:17
mversic
reviewed
Mar 13, 2024
mversic
requested changes
Mar 13, 2024
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
0x009922
force-pushed
the
4059-snapshots-config
branch
from
March 14, 2024 01:10
ee6831a
to
350df55
Compare
VAmuzing
approved these changes
Mar 14, 2024
mversic
approved these changes
Mar 14, 2024
Pull Request Test Coverage Report for Build 8273909280Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config-changes
Changes in configuration and start up of the Iroha
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mode
of snapshots behaviour:read_write
,readonly
, anddisabled
SnapshotMaker
actor only inread_write
modesnapshot.creation_enabled
, addsnapshot.mode
Linked issue
Closes #4059, #4296
Benefits
More expected behaviour of snapshots for users?