-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #4315: split pipeline events #4366
Merged
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:split_pipeline_events
Mar 28, 2024
Merged
[refactor] #4315: split pipeline events #4366
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:split_pipeline_events
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Refactor
Improvement to overall code quality
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
labels
Mar 14, 2024
mversic
force-pushed
the
split_pipeline_events
branch
6 times, most recently
from
March 14, 2024 07:56
59c27fb
to
94aa11e
Compare
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
March 14, 2024 07:57
mversic
force-pushed
the
split_pipeline_events
branch
2 times, most recently
from
March 14, 2024 09:08
4b628a6
to
8b760fe
Compare
Can merging this please be postponed to after #4240 lands? I don't want to rebase it again.. |
DCNick3
reviewed
Mar 14, 2024
mversic
force-pushed
the
split_pipeline_events
branch
2 times, most recently
from
March 14, 2024 10:20
5f60347
to
52ee097
Compare
mversic
force-pushed
the
split_pipeline_events
branch
2 times, most recently
from
March 19, 2024 07:26
c010136
to
b097945
Compare
mversic
force-pushed
the
split_pipeline_events
branch
11 times, most recently
from
March 25, 2024 11:05
2dcde0e
to
f87bc28
Compare
Erigara
reviewed
Mar 25, 2024
Erigara
previously approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a lot semi related changes, consider to make separate PR for them in the future, it will make it easier to review.
Other than that look good.
mversic
force-pushed
the
split_pipeline_events
branch
4 times, most recently
from
March 27, 2024 08:39
576dcc0
to
1815470
Compare
Pull Request Test Coverage Report for Build 8455027251Details
💛 - Coveralls |
DCNick3
reviewed
Mar 27, 2024
mversic
force-pushed
the
split_pipeline_events
branch
from
March 27, 2024 16:11
1815470
to
5b5db88
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
split_pipeline_events
branch
from
March 27, 2024 16:13
5b5db88
to
f28b04b
Compare
DCNick3
approved these changes
Mar 27, 2024
Erigara
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
config-changes
Changes in configuration and start up of the Iroha
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
QA-confirmed
This bug is reproduced and needs a fix
Refactor
Improvement to overall code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WithEvents
which makes sure that events are consumed upon block state transitionPipelineEvent
to a more sane representationLinked issue
Closes #4315
Benefits
Checklist
CONTRIBUTING.md