Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For dummy events, minimum of 3 events? #68

Open
heymarkreeves opened this issue Nov 4, 2014 · 3 comments
Open

For dummy events, minimum of 3 events? #68

heymarkreeves opened this issue Nov 4, 2014 · 3 comments
Assignees

Comments

@heymarkreeves
Copy link
Collaborator

Hi, Liam!

As we're aiming to display a minimum of 3 events in the bottom carousel, can you pad the API results so that the API returns 0 or 3+ events? If only 1 event is returned, we'd need 2 dummy items; If 2 events come back, we'd need 1 dummy item.

Thanks!

Mark

/cc @desigonz

@mailbackwards
Copy link
Collaborator

PR #67 is attempting to resolve this:

  • the favorites endpoint should return either 0 or 3+ events, with dummies filling out the others (currently it's a blank white image but we can fix that quickly anytime, of course)
  • the related_events endpoint will return 3+ events (it should never have 0, or else it wouldn't be related)

The other bottom-carousel endpoints I see are "around me" and "by venue." I'll look into those soon. Are there others that I'm forgetting?

@SherriAlexander
Copy link

Hey there, Liam! Those are the four footer slider endpoints, you haven't missed any. :) Thanks!

@mailbackwards
Copy link
Collaborator

I added dummies to the other two endpoints as well-- this is now merged and deployed. The hyperlink is still active for the dummy events, but otherwise I think it looks right on this end!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants