Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more smoke test and framework how to add more tests #217

Open
pavolloffay opened this issue Jan 11, 2021 · 2 comments
Open

Add more smoke test and framework how to add more tests #217

pavolloffay opened this issue Jan 11, 2021 · 2 comments

Comments

@pavolloffay
Copy link
Member

Add smoke tests for gRPC and different servlet containers (similar to https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/master/smoke-tests/matrix).

The images for these should be in control of this project, build as part of the smoke-test job. It should be easy to add smoke tests for new frameworks.

@pavolloffay
Copy link
Member Author

We can certainly adopt OTEL smoke tests, my requirements are:

  • test capturing of payloads
  • test capturing of headers
  • the test images should be built and published to HT docker registry - e.g. ghcr or dockerhub

@samarth-gupta-traceable
Copy link
Contributor

@pavolloffay here the 2 steps I propose to integrate and modify OTEL smoke test with HT java agent:

  1. Import current test from OTEL to HT repo and make sure all test are passing with hypertrace-agent-all.jar . This will require changes in smoke test as well as gradle files. This will include changes for publishing images to HT docker registry.
  2. Enhance test app to send POST requests with required headers & add validation by enhancing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants