-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Improve the existing search + filtering interface #1289
Comments
At present, this issue is too vague to prioritize on our product board. We first need to determine:
@ajpeddakotla, I suggest you and I tackle the first item above - perhaps this card can serve as an epic |
A number of search and filtering issues were raised by our recent grading work— issues that affect all users, not just LMS users. These issues were de-prioritized at the time in favor of getting our grading feature out the door ASAP. In a recent conversation with @lyzadanger, she suggested that now could be a good time to address these problems, while we are in between finishing up some major projects and getting ready to start our next big pieces of work. I agree that the timing is good, since it's unlikely that we'll return to grading-related work for a while. And the overlap of the search bar + group name is particularly egregious. Specific problems we're looking to solve: Overlap between group name and search barhappens with any group name longer than 12 characters. And the whole point of our 25-character group limit is fear of this happening. Fixing this could allow us to increase the character limit for group names. Replying to an annotation when a search filter is repliedIf you have a search applied and you try to reply to one of the visible annotations, your new reply will be immediately hidden and you’ll see “Show 1 more in conversation”. You can expand that and fill out the reply and save it—but then it gets immediately hidden again. Misleading/confusing search result UXonce you expand any “hidden” threads via the “Show x more…” buttons, the “search results” count changes and is misleading—yes, we’re showing 2 annotations now, but they are not “search results.” Some of this filtering UX stress is compounded in the user-focused mode (i.e. LMS grading mode). This interface isn’t terrible, but the isolation of “Showing 1 annotation” from the user-filter information is less than totally ideal: if the instructor expands hidden threads, the “Showing 5 annotations” count here is accurate, but there’s no way to get back to showing just Freddy Potato’s actual annotations: And, with user-filtered mode, applying a search on top of the user filtering works but has a less-than-clear interface (and breaks down as soon as one expands any hidden threads): This work would allow us to address a long list of issues, including:
This issue can serve as an epic - if @lyzadanger 's work encompasses anything not listed in these issues, she can open separate issues and link them here. |
Some of these issues were fixed as part of the new search UI - #6006 (comment). I'm going to call this "done" and new issues can be filed for the other problems. |
EDIT - May 2020
This will serve as an epic, tracking the following issues:
Problem:
In the discussion of this issue: (#1241), one of the things that was mentioned was considering improvements to the existing search interface of the client. When we implemented activity pages, we created a new and cleaner search interface that included suggestions for the users, the use of lozenges to define search terms, among other things.
The the search functionality of the client was never updated to reflect those changes. It is clunky, not responsive to user inputs and doesn't "focus" the annotations that reflect search terms.
This issue has been created to propose the changes we want to make to the search feature in the client. Additionally, given that we will redo activity pages in the future, we are not married to the search feature there - we can take the best practices we learned from that work and carry them over here.
The text was updated successfully, but these errors were encountered: