Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish matching and non-matching annotations and replies when the sidebar is filtered #1242

Open
seanh opened this issue Jul 11, 2019 · 2 comments

Comments

@seanh
Copy link
Contributor

seanh commented Jul 11, 2019

When a search filter is applied in the sidebar (for example filtered to show just one annotation after following a bouncer link; to show just one group; just one user; to match an arbitrary keyword search, ...) add a clear visual distinction between the annotations and replies that match the filer vs other annotations and replies that're being shown because they're in an expanded part of the same thread as one of the matching annotations.

While this will be a general improvement to client UX, it'll be particularly important when a teacher is using the client to grade a student's annotations in an LMS, and the client is filtered to match the annotations and replies of the student being graded.

@dwhly
Copy link
Member

dwhly commented Jul 11, 2019

Question: Are the "other annotations and replies that're being shown" visible from the outset if such a filter is in place, or are they only visible after some action (expanding a collapsed thread, or clicking "show all annotations")?

@seanh
Copy link
Contributor Author

seanh commented Jul 11, 2019

Same behaviour as currently: only visible after expanding part of a thread. No behaviour change is proposed here just a visual change to the matching and non-matching annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants