Creating a new highlight removes highlights which have not been saved to the server

[robertknight]

Steps to reproduce

1. Activate Hypothesis on a page
2. Severely throttle the network connection (enough that you can perform step 4 before the network request triggered by step 3 has completed)
3. Select a piece of text and click 'Highlight' to create a highlight
4. Select a different piece of text and click 'Highlight' to create a second highlight. (You can tell if the highlight created at step 3 has been saved to the server yet by looking at whether Reply/Edit actions are displayed underneath it in the sidebar)

Expected behaviour

The highlight created in step 3 should continue to exist after step 4

Actual behaviour

The highlight created in step 3 is removed in step 4

Browser/system information

Tested with Chrome v55 and Hypothesis v0.46

[robertknight]

The workaround for users is to wait until the highlight is saved, indicated by the Edit / Delete / Reply etc. actions appearing underneath the highlight in the sidebar.

[jonjitsu]

I experience this bug so much the extension is unusable. It is as though once you hit a certain number of highlights no more can be created for the page.

[robertknight]

This issue has been fixed. The code which autosaves new highlights to the server was rewritten:

client/src/sidebar/services/autosave.js

Line 28 in e8488b4

const autosaveNewHighlights = () => {

.