Merging of buckets into top/bottom buckets happens at unexpected position #5525
Comments
robertknight
added a commit
that referenced
this issue
Jun 8, 2023
Use the position of the center of an anchor instead of the top to determine whether it should be counted as off-screen or not. Since buckets in the bucket bar are drawn where the center is, this ensures that on-screen buckets merge into off-screen ones at a natural point, instead of when there is still a gap between the two (for the "above screen" bucket) or after the on-screen bucket has gone below the "below screen" bucket. Fixes #5525
robertknight
added a commit
that referenced
this issue
Jun 8, 2023
Use the position of the center of an anchor instead of the top to determine whether it should be counted as off-screen or not. Since buckets in the bucket bar are drawn where the center is, this ensures that on-screen buckets merge into off-screen ones at a natural point, instead of when there is still a gap between the two (for the "above screen" bucket) or after the on-screen bucket has gone below the "below screen" bucket. Fixes #5525
robertknight
added a commit
that referenced
this issue
Jun 12, 2023
Use the position of the center of an anchor instead of the top to determine whether it should be counted as off-screen or not. Since buckets in the bucket bar are drawn where the center is, this ensures that on-screen buckets merge into off-screen ones at a natural point, instead of when there is still a gap between the two (for the "above screen" bucket) or after the on-screen bucket has gone below the "below screen" bucket. Fixes #5525
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When highlights get near enough to the top/bottom of the screen, their buckets alongside the sidebar get merged into a single bucket for all highlights above/below the screen respectively. For short highlights, this happens as the dedicated bucket touches the "offscreen" bucket, which feels natural. For tall highlights however, this can happen when the dedicated bucket has still a significant gap to the "above screen" bucket, or has already gone some way past the "below screen" bucket.
The reason this happens is because the merging happens based on where the top of the highlight is. However the dedicated bucket is rendered where the center of the highlight is.
In the screenshot below, the
< 1bucket will merge into the^ 2bucket long before they touch, when scrolling up. When scrolling down, it will merge into theV 2bucket long after they touch.The text was updated successfully, but these errors were encountered: