Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into possibility of being able to attach bucket bar to transcript container in video player #5488

Closed
4 tasks done
robertknight opened this issue May 24, 2023 · 4 comments

Comments

@robertknight
Copy link
Member

robertknight commented May 24, 2023

In the in-development video player app, all the annotatable content is in the transcript container. The bucket bar however is in its usual location on the right side of the screen:

Video app bucket bar

I find that these buckets end up being hard to see / easy to miss as they are visually detached from the container that scrolls. A possibility that we want to explore instead is attaching the bucket bar to the transcript container. This might be connected to preventing annotation of content outside of the transcript.

@robertknight
Copy link
Member Author

Some technical issues we'd need to work through:

  • How does the host page specify a container to attach the bucket bar to?
  • The bucket bar currently lives inside the <hypothesis-sidebar> shadow DOM, which isolates it from the page's styles. We'd probably need to extract it into its own custom element with its own shadow DOM.

@robertknight
Copy link
Member Author

Work being done in this PR: #5524

@lyzadanger
Copy link
Contributor

@robertknight Looks like maybe this one is good to close? Yay!

@robertknight
Copy link
Member Author

Yes, this is good to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants