Use center rather than top position of anchor for bucket-on-screen test #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the position of the center of an anchor instead of the top to determine whether it should be counted as off-screen or not. Since buckets in the bucket bar are drawn where the center is, this ensures that on-screen buckets merge into off-screen ones at a natural point, instead of when there is still a gap between the two (for the "above screen" bucket) or after the on-screen bucket has gone below the "below screen" bucket. Fixes #5525
robertknight
force-pushed
the
use-center-pos-for-bucket-on-screen-test
branch
from
859ab77
to
fbea415
Compare
Codecov Report
@@ Coverage Diff @@
## main #5526 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 238 238
Lines 9421 9422 +1
Branches 2244 2244
=======================================
+ Hits 9351 9352 +1
Misses 70 70
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'm going to get this merged, but @lyzadanger you might still want to be aware of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the position of the center of an anchor instead of the top to determine whether it should be counted as off-screen or not. Since buckets in the bucket bar are drawn where the center is, this ensures that on-screen buckets merge into off-screen ones at a natural point, instead of when there is still a gap between the two (for the "above screen" bucket) or after the on-screen bucket has gone below the "below screen" bucket.
Fixes #5525