Skip to content

Commit

Permalink
Fix existing lint errors in H service scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
robertknight committed Jul 29, 2016
1 parent a66ff07 commit 795c2ee
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 10 deletions.
2 changes: 1 addition & 1 deletion h/static/scripts/create-group-form.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function CreateGroupFormController(element) {
self._groupNameInput.addEventListener('input', groupNameChanged);
groupNameChanged();

this._infoLink.addEventListener('click', function (event) {
this._infoLink.addEventListener('click', function () {
event.preventDefault();
self._infoLink.classList.add('is-hidden');
self._infoText.classList.remove('is-hidden');
Expand Down
4 changes: 2 additions & 2 deletions h/static/scripts/karma.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = function(config) {
'browserify',
'mocha',
'chai',
'sinon'
'sinon',
],

// list of files / patterns to load in the browser
Expand Down Expand Up @@ -45,7 +45,7 @@ module.exports = function(config) {
debug: true,
configure: function (bundle) {
bundle.plugin('proxyquire-universal');
}
},
},

mochaReporter: {
Expand Down
7 changes: 4 additions & 3 deletions h/static/scripts/legacy-site.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ require('bootstrap');

if (window.chrome !== undefined) {
var elements = document.getElementsByClassName('unhide-in-chrome');
for (var i = 0; i < elements.length; i++) {
var i;
for (i = 0; i < elements.length; i++) {
elements[i].classList.remove('hidden');
}
elements = document.getElementsByClassName('hide-in-chrome');
for (var i = 0; i < elements.length; i++) {
for (i = 0; i < elements.length; i++) {
elements[i].classList.add('hidden');
}
}
Expand All @@ -25,7 +26,7 @@ if (bookmarkletInstaller) {
var chromeextInstaller = document.getElementById('js-chrome-extension-install');
if (chromeextInstaller) {
chromeextInstaller.addEventListener('click', function (event) {
chrome.webstore.install();
window.chrome.webstore.install();
event.preventDefault();
});
}
2 changes: 2 additions & 0 deletions h/static/scripts/test/bootstrap.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
'use strict';

// Expose the sinon assertions.
sinon.assert.expose(assert, {prefix: null});
2 changes: 1 addition & 1 deletion h/static/scripts/test/create-group-form-test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"use strict";
'use strict';

var CreateGroupFormController = require('../create-group-form');

Expand Down
6 changes: 3 additions & 3 deletions h/static/scripts/test/raven-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ function fakeExceptionData(scriptURL) {
stacktrace: {
frames: [{
filename: scriptURL,
}]
}
}]
}],
},
}],
},
culprit: scriptURL,
};
Expand Down

0 comments on commit 795c2ee

Please sign in to comment.