Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the script loader and polyfill situation #346

Closed
tilgovi opened this issue Mar 27, 2013 · 12 comments
Closed

clean up the script loader and polyfill situation #346

tilgovi opened this issue Mar 27, 2013 · 12 comments

Comments

@tilgovi
Copy link
Contributor

tilgovi commented Mar 27, 2013

Right now I have a copy of yepnope.js copied into the embed code template.

Problems with it include:

  • Small number of tests and polyfills. We could do slightly better I bet.
  • The asset bundling is cumbersome.

We should probably remove yepnope in favor of a server-side include of a modernizr build and access the webassets bundles by name more directly from the template, like we do in app.pt, rather than passing them all from the embed code view.

@csillag
Copy link
Contributor

csillag commented Sep 19, 2013

Why does this issue have the "mobile" label?

@tilgovi
Copy link
Contributor Author

tilgovi commented Sep 19, 2013

No idea.

@tilgovi
Copy link
Contributor Author

tilgovi commented Feb 5, 2014

This is what I'm thinking these days: https://github.com/cujojs/curl

@BigBlueHat
Copy link
Contributor

Going to give this another look in relation to #1445 . Yepnope also adds some lag on the FF extension, so I believe its time has come.

@aron
Copy link
Contributor

aron commented Aug 26, 2014

@BigBlueHat think you meant #1445.

@BigBlueHat
Copy link
Contributor

Yep. He did. 😄

@BigBlueHat
Copy link
Contributor

@tilgovi @aron @csillag

To replace yepnope.js, we need:

  • feature detection & conditional script loading?
  • in-order JS asset loading / processing?
  • post-asset-loading call back triggering?

@tilgovi
Copy link
Contributor Author

tilgovi commented Sep 4, 2014

That's about right.
On Sep 4, 2014 6:18 AM, "BigBlueHat" notifications@github.com wrote:

@tilgovi https://github.com/tilgovi @aron https://github.com/aron
@csillag https://github.com/csillag

To replace yepnope.js, we need:

  • feature detection & conditional script loading?
  • in-order JS asset loading / processing?
  • post-asset-loading call back triggering?


Reply to this email directly or view it on GitHub
#346 (comment).

@BigBlueHat
Copy link
Contributor

@tilgovi all 3?

@tilgovi
Copy link
Contributor Author

tilgovi commented Sep 4, 2014

Yes. But doesn't all have to be in one package. For instance, modernizr +
cURLjs
On Sep 4, 2014 10:11 AM, "BigBlueHat" notifications@github.com wrote:

@tilgovi https://github.com/tilgovi all 3?


Reply to this email directly or view it on GitHub
#346 (comment).

@tilgovi
Copy link
Contributor Author

tilgovi commented Sep 27, 2014

Things are a bit neater with the embed code now, but we should still switch to a module system so we can load everything async or bundle it all. Also, yepnope development has been discontinued.

@aron
Copy link
Contributor

aron commented Nov 7, 2014

Closed by #1639

@aron aron closed this as completed Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants