Add a docker-compose.yml for services #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running the h development server itself inside Docker using Compose is a bit fiddly and possibly not what we want to do, using Compose to coordinate the backing services seems to be straightforward and helpful. Add a docker-compose.yml which configures the Postgres, Elasticsearch, and RabbitMQ containers, and update the dev documentation to use it.
Codecov Report
@@ Coverage Diff @@
## master #4380 +/- ##
======================================
Coverage 94.2% 94.2%
======================================
Files 315 315
Lines 17847 17847
Branches 1057 1057
======================================
Hits 16812 16812
+ Misses 936 933 -3
- Partials 99 102 +3
Continue to review full report at Codecov.
|
dhwthompson
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the h development server itself inside Docker using Compose is a bit fiddly and possibly not what we want to do, using Compose to coordinate the backing services seems to be straightforward and helpful.
Add a docker-compose.yml which configures the Postgres, Elasticsearch, and RabbitMQ containers, and update the dev documentation to use it.