Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade pyramid_mailer and repoze.sendmail #4482
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov-io
Apr 5, 2017
Codecov Report
Merging #4482 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@
## master #4482 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 354 354
Lines 18774 18774
Branches 1084 1084
=======================================
Hits 17757 17757
+ Misses 908 905 -3
- Partials 109 112 +3| Impacted Files | Coverage Δ | |
|---|---|---|
| h/search/__init__.py | 38.88% <0%> (ø) |
|
| h/session.py | 91.83% <0%> (ø) |
|
| h/stats.py | 83.33% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 7dd19a4...4537d73. Read the comment docs.
codecov-io
commented
Apr 5, 2017
Codecov Report
@@ Coverage Diff @@
## master #4482 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 354 354
Lines 18774 18774
Branches 1084 1084
=======================================
Hits 17757 17757
+ Misses 908 905 -3
- Partials 109 112 +3
Continue to review full report at Codecov.
|
chdorner
approved these changes
Apr 5, 2017
LGTM. I tested it locally, but I'm not sure if the local email sending interceptor functionality actually tests any of these package upgrades. We might just have to put it on QA and see (although everything should hopefully be fine anyway).
nickstenning commentedApr 5, 2017
A long-standing bug in repoze.sendmail has now been fixed (repoze/repoze.sendmail#38), which means we can finally remove our version pin for this package.