Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyramid_mailer and repoze.sendmail #4482

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Conversation

nickstenning
Copy link
Contributor

A long-standing bug in repoze.sendmail has now been fixed (repoze/repoze.sendmail#38), which means we can finally remove our version pin for this package.

A long-standing bug in repoze.sendmail has now been fixed
(repoze/repoze.sendmail#38), which means we can
finally remove our version pin for this package.
@codecov-io
Copy link

Codecov Report

Merging #4482 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4482   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files         354      354           
  Lines       18774    18774           
  Branches     1084     1084           
=======================================
  Hits        17757    17757           
+ Misses        908      905    -3     
- Partials      109      112    +3
Impacted Files Coverage Δ
h/search/__init__.py 38.88% <0%> (ø) ⬆️
h/session.py 91.83% <0%> (ø) ⬆️
h/stats.py 83.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd19a4...4537d73. Read the comment docs.

Copy link
Contributor

@chdorner chdorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested it locally, but I'm not sure if the local email sending interceptor functionality actually tests any of these package upgrades. We might just have to put it on QA and see (although everything should hopefully be fine anyway).

@chdorner chdorner merged commit 3e900fe into master Apr 5, 2017
@chdorner chdorner deleted the upgrade-mailer branch April 5, 2017 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants