Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset 'tpc_phase' to zero during 'tpc_abort' / 'tpc_finish'. #38

Merged
merged 1 commit into from
Dec 7, 2016

Conversation

tseaver
Copy link
Member

@tseaver tseaver commented Dec 7, 2016

Closes #31.

/cc @mmerickel

@mmerickel
Copy link

I'll try in the next half hour here to see if I can reproduce the old error and then upgrade to see if this patch fixes it. Thanks.

@mmerickel
Copy link

I can confirm this fix appears to be working for me.

@tseaver tseaver merged commit 44a1608 into master Dec 7, 2016
@tseaver tseaver deleted the 31-reset-tpc_phase branch December 7, 2016 18:51
@papachoco
Copy link

Thank a lot

@mmerickel
Copy link

Is this going to get released soon?

@tseaver
Copy link
Member Author

tseaver commented Dec 8, 2016

I was looking at other open PRs: I asked for changes on #37, which is straightforward to apply. The others (#25, #26, #34, #35) take more cycles than I have available today.

@tseaver
Copy link
Member Author

tseaver commented Dec 8, 2016

@mmerickel released

tseaver added a commit that referenced this pull request Dec 8, 2016
nickstenning added a commit to hypothesis/h that referenced this pull request Apr 5, 2017
A long-standing bug in repoze.sendmail has now been fixed
(repoze/repoze.sendmail#38), which means we can
finally remove our version pin for this package.
chdorner pushed a commit to hypothesis/h that referenced this pull request Apr 5, 2017
A long-standing bug in repoze.sendmail has now been fixed
(repoze/repoze.sendmail#38), which means we can
finally remove our version pin for this package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants