Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --redirect_uri and --grant-type arguments to the bin/hypothesis authclient add command #7965

Merged
merged 3 commits into from
May 10, 2023

Conversation

bpow
Copy link
Contributor

@bpow bpow commented May 2, 2023

Addresses #7009, adding functionality to the cli tool that otherwise would only be possible in the web interface. Useful for scripting addition of an authclient (e.g., for provisioning
or testing).

This is the same as #7297 rebased against current main. That PR was closed (multiple times) as stale without review by anyone on the main development team (see also issue #7572)

Addresses hypothesis#7009, adding functionality to the cli tool that otherwise
would only be possible in the web interface. Useful for scripting addition
of an authclient.
@seanh seanh changed the title add redirect_uri and grant_type to authclient Add --redirect_uri and --grant-type arguments to to bin/hypothesis authclient add command May 10, 2023
@seanh seanh changed the title Add --redirect_uri and --grant-type arguments to to bin/hypothesis authclient add command Add --redirect_uri and --grant-type arguments to the bin/hypothesis authclient add command May 10, 2023
@seanh seanh self-assigned this May 10, 2023
Copy link
Contributor

@seanh seanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Thanks @bpow. I've pushed a couple of commits to:

  1. Disable a pylint warning (so that make lint passes)
  2. Fix the code formatting (so that make checkformatting passes) by running the automatic code formatter (make format)

@seanh seanh merged commit dbe461c into hypothesis:main May 10, 2023
@bpow bpow deleted the authclient-args branch January 17, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants