Model for annotation metadata #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
annotation-metadata-model
branch
from
270cc77
to
e64ca27
Compare
marcospri
force-pushed
the
annotation-metadata-migration
branch
from
f8f568d
to
55c030a
Compare
marcospri
force-pushed
the
annotation-metadata-model
branch
from
e64ca27
to
9bb1fd9
Compare
marcospri
commented
Sep 6, 2023
h/models/annotation_metadata.py
Outdated
| unique=True, | ||
| ) | ||
|
|
||
| meta = sa.Column( |
There was a problem hiding this comment.
metadata can't be a model attribute. I've gone for meta in the model and metadata in the table.
Should both (model and table) but just be meta?
There was a problem hiding this comment.
Yeah, I've been using this in some follow up PRs and the meta/metadata idea was awful. data it is
marcospri
force-pushed
the
annotation-metadata-model
branch
from
9bb1fd9
to
2c3bfaf
Compare
seanh
approved these changes
Sep 7, 2023
h/models/annotation_metadata.py
Outdated
| unique=True, | ||
| ) | ||
|
|
||
| meta = sa.Column( |
marcospri
force-pushed
the
annotation-metadata-migration
branch
from
55c030a
to
314ec92
Compare
marcospri
force-pushed
the
annotation-metadata-model
branch
from
2c3bfaf
to
10c2e26
Compare
marcospri
force-pushed
the
annotation-metadata-model
branch
from
10c2e26
to
3265493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration changes over: