Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the path to the upload folder needs to be a setting #28

Closed
judell opened this issue Oct 5, 2017 · 4 comments
Closed

the path to the upload folder needs to be a setting #28

judell opened this issue Oct 5, 2017 · 4 comments

Comments

@judell
Copy link
Contributor

judell commented Oct 5, 2017

The PDF feature works by prepending https://via.hypothes.is to links in posts that point into the media upload folder, by default wp-content/uploads. But if your WP system refers to a different place, you're out of luck. So, the path to that folder should be a setting.

@greatislander
Copy link

Hi @judell! You should be able to use wp_upload_dir()['basedir'] to get the correct /uploads path on any system.

@judell
Copy link
Contributor Author

judell commented Oct 6, 2017

Aha. Thanks Ned! Next step, I guess, work out how to transmit that value from PHP to JS.

@greatislander
Copy link

Fixed by #27, I think!

@acelaya
Copy link
Contributor

acelaya commented Feb 29, 2024

Closing as fixed

@acelaya acelaya closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants