Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: cursor_inactive_timeout is broken #3698

Closed
andresilva opened this issue Oct 30, 2023 · 11 comments · Fixed by #4780
Closed

regression: cursor_inactive_timeout is broken #3698

andresilva opened this issue Oct 30, 2023 · 11 comments · Fixed by #4780
Labels
bug Something isn't working

Comments

@andresilva
Copy link
Contributor

andresilva commented Oct 30, 2023

Hyprland Version

1c9d6b9

Bug or Regression?

Regression

Description

Dispatching movefocus now activates the cursor. Did a bisect, regression was introduced in 7a5234a.

How to reproduce

  • enable cursor_inactive_timeout
  • move window focus
  • cursor reappears

Crash reports, logs, images, videos

No response

@andresilva andresilva added the bug Something isn't working label Oct 30, 2023
@vaxerski
Copy link
Member

why didnt you select "regression" then?

@andresilva
Copy link
Contributor Author

andresilva commented Oct 30, 2023

What do you mean? There are two issue templates: bug and feature request. Nevermind, because I was dumb.

@vaxerski
Copy link
Member

:)

@andresilva
Copy link
Contributor Author

friendly ping. I tried to debug this but couldn't figure it out.

@dusanx
Copy link
Contributor

dusanx commented Dec 16, 2023

I have started working on this, MR should be ready in a few. Cursor is being rewritten/forced in a weird way so fix requires slight logic change with cursor handling. I didn't go all the way trough code, so far seems very fixable.

@andresilva
Copy link
Contributor Author

Fixed in #4184. Thanks @dusanx!

@andresilva
Copy link
Contributor Author

Broken by: b500e56

When you move focus to a place where the cursor should change it gets re-activated.

@andresilva andresilva reopened this Feb 19, 2024
@vaxerski
Copy link
Member

patch.txt

what if

@andresilva
Copy link
Contributor Author

Solves the issue, although when the cursor is recovered it might not be using the correct cursor for the surface.

@vaxerski
Copy link
Member

hm, right.

@andresilva
Copy link
Contributor Author

andresilva commented Feb 20, 2024

FWIW this isn't any different than it was before so it's probably worth it to merge that patch anyway (the changes in setCursorFromName aren't needed though).

patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants