Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(binds): avoid onWindowRemoved & onWindowCreated when group has one member #3286

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

memchr
Copy link
Contributor

@memchr memchr commented Sep 13, 2023

Make moveWindowOutOfGroup behave like toggleGroup on a group with single
member, this prevents the window from moving around unpredictably.

…as one member

Make moveWindowOutOfGroup behave like toggleGroup on a group with single
member, this prevents the window from moving around rabidly.
vaxerski
vaxerski previously approved these changes Sep 13, 2023
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, thanks!

@vaxerski
Copy link
Member

conflict tho I believe from your other mr

@memchr
Copy link
Contributor Author

memchr commented Sep 13, 2023

resolved.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g

@vaxerski vaxerski merged commit 4f88897 into hyprwm:main Sep 13, 2023
11 checks passed
thejch pushed a commit to thejch/Hyprland that referenced this pull request Sep 13, 2023
…member (hyprwm#3286)

Make moveWindowOutOfGroup behave like toggleGroup on a group with single
member, this prevents the window from moving around rabidly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants