keybinds: avoid onWindowRemoved & onWindowCreated when group has one …

…member (hyprwm#3286) Make moveWindowOutOfGroup behave like toggleGroup on a group with single member, this prevents the window from moving around rabidly.
thejch · Sep 13, 2023 · a3aae26 · a3aae26
1 parent 5ad50d6
commit a3aae26
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/managers/KeybindManager.cpp b/src/managers/KeybindManager.cpp
@@ -1977,15 +1977,19 @@ void CKeybindManager::moveWindowOutOfGroup(CWindow* pWindow, const std::string&
         default: direction = DIRECTION_DEFAULT;
     }
 
-    g_pLayoutManager->getCurrentLayout()->onWindowRemoved(pWindow);
-
-    const auto GROUPSLOCKEDPREV = g_pKeybindManager->m_bGroupsLocked;
+    if (pWindow->m_sGroupData.pNextWindow == pWindow) {
+        pWindow->m_sGroupData.pNextWindow = nullptr;
+        pWindow->updateWindowDecos();
+    } else {
+        g_pLayoutManager->getCurrentLayout()->onWindowRemoved(pWindow);
 
-    g_pKeybindManager->m_bGroupsLocked = true;
+        const auto GROUPSLOCKEDPREV        = g_pKeybindManager->m_bGroupsLocked;
+        g_pKeybindManager->m_bGroupsLocked = true;
 
-    g_pLayoutManager->getCurrentLayout()->onWindowCreated(pWindow, direction);
+        g_pLayoutManager->getCurrentLayout()->onWindowCreated(pWindow, direction);
 
-    g_pKeybindManager->m_bGroupsLocked = GROUPSLOCKEDPREV;
+        g_pKeybindManager->m_bGroupsLocked = GROUPSLOCKEDPREV;
+    }
 
     if (*BFOCUSREMOVEDWINDOW) {
         g_pCompositor->focusWindow(pWindow);