New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dropout should comes before residual connection and layer norm #8

Closed

ayaka14732 opened this issue Mar 31, 2022 · 1 comment

Contributor

ayaka14732 commented Mar 31, 2022

In section 5.4 of the original paper:

We apply dropout to the output of each sub-layer, before it is added to the sub-layer input and normalized.

Owner

hyunwoongko commented Dec 7, 2022

Fixed.

hyunwoongko closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment