feature/model-improvements #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
force-pushed
the
feature/REDBOX-94-various-model-improvements
branch
from
2e060ce
to
91d78b7
Compare
gecBurton
commented
Mar 28, 2024
gecBurton
commented
Mar 28, 2024
gecBurton
commented
Mar 28, 2024
gecBurton
commented
Mar 28, 2024
| storage_kind: str = "local" | ||
| text: str = "" | ||
| processing_status: ProcessingStatusEnum = ProcessingStatusEnum.uploaded | ||
| text: Optional[str] = Field(description="file content", default=None) |
There was a problem hiding this comment.
we could set this to be a required field if we had an IngestQueueItem to reference the file rather than reusing this class?
lmwilkigov
approved these changes
Mar 29, 2024
Co-authored-by: George Burton <8233643+gecBurton@users.noreply.github.com>
Co-authored-by: George Burton <8233643+gecBurton@users.noreply.github.com>
Co-authored-by: George Burton <8233643+gecBurton@users.noreply.github.com>
gecBurton
force-pushed
the
feature/REDBOX-94-various-model-improvements
branch
from
36657af
to
e147076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We can make more use of pydantic's models:
This work is incomplete, but this change is already big enough
Changes proposed in this pull request
many and various
Guidance to review
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-94
Things to check