bugfix/added default elastic settings #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2024 08:07
gecBurton
commented
Apr 12, 2024
| @@ -25,7 +27,7 @@ class Settings(BaseSettings): | |||
| anthropic_api_key: Optional[str] = None | |||
| openai_api_key: Optional[str] = None | |||
|
|
|||
| elastic: ElasticCloud | ElasticLocal | |||
| elastic: ElasticCloudSettings | ElasticLocalSettings = ElasticLocalSettings() | |||
There was a problem hiding this comment.
this is the key change
rachaelcodes
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Integration test are failing on main
Changes proposed in this pull request
The reason is that we did not have default Elastic Settings, this has been added
Guidance to review
Relevant links
https://github.com/i-dot-ai/redbox-copilot/actions/runs/8658385003
Things to check