Feature/redbox 4 setup mypy for type hinting testing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
commented
Feb 17, 2024
| @@ -143,10 +143,10 @@ def merge_chunk_metadata(meta_in: List[Dict]) -> Dict: | |||
| Combine metadata for multiple chunks from the same document. | |||
| """ | |||
| # collect all the possible key values | |||
| all_keys = set() | |||
| all_keys: set = set() | |||
There was a problem hiding this comment.
why mypy insists we do this i will never know!
gecBurton
commented
Feb 17, 2024
|
|
||
| @computed_field | ||
| def model_type(self) -> str: | ||
| return self.__class__.__name__ |
There was a problem hiding this comment.
I wasn't sure that this would resolve properly for child classes, i.e. would this fucntion always return "PersistableModel". however there are two existing test for this that show this working as expected
gecBurton
commented
Feb 17, 2024
| """ | ||
| if os.environ["CACHE_LLM_RESPONSES"] == "true": | ||
| set_llm_cache(SQLiteCache(database_path=os.environ["CACHE_LLM_DB"])) | ||
|
|
||
| self.docs_with_sources_chain = load_qa_with_sources_chain( |
There was a problem hiding this comment.
gecBurton
commented
Feb 18, 2024
| @@ -77,7 +77,7 @@ def delete_item(self, item_uuid: str, model_type: str): | |||
|
|
|||
| def delete_items(self, item_uuids: List[str], model_type: str): | |||
| target_index = f"{self.root_index}-{model_type.lower()}" | |||
| result = self.es_client.mdelete(index=target_index, body={"ids": item_uuids}) | |||
| result = self.es_client.mdelete(index=target_index, body={"ids": item_uuids}) # type: ignore | |||
There was a problem hiding this comment.
does mdelete exist?
There was a problem hiding this comment.
I think this is a typo and I've never actually called this method to spot it
gecBurton
commented
Feb 18, 2024
gecBurton
commented
Feb 19, 2024
gecBurton
commented
Feb 19, 2024
| chat_history: Optional[List] = [], | ||
| callbacks: Optional[List] = [], | ||
| ) -> dict: | ||
| chat_history: Optional[list] = None, |
There was a problem hiding this comment.
lmwilkigov
approved these changes
Feb 19, 2024
lmwilkigov
deleted the
feature/REDBOX-4-setup-mypy-for-type-hinting-testing
branch
lmwilkigov
added a commit
that referenced
this pull request
Mar 8, 2024
…type-hinting-testing Feature/redbox 4 setup mypy for type hinting testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
mypy checks the code for type errors.
Changes proposed in this pull request
checktypesand is used in CI.checktypes.# type: ignorewhere we are using@computed_field.typing.Listas been replaced withlistetcGuidance to review
Link to JIRA ticket
https://technologyprogramme.atlassian.net/browse/REDBOX-4
Things to check
- [ ] I have added any new ENV vars in all deployed environments