Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled PulseAudio files #11

Closed
tataranovich opened this issue Oct 2, 2014 · 3 comments
Closed

Bundled PulseAudio files #11

tataranovich opened this issue Oct 2, 2014 · 3 comments

Comments

@tataranovich
Copy link

Hello Rinat,

First of all thank you for your job and this software.

I'm curious why you bundled pulseaudio headers instead of to require pulseaudio development files as build dependency. In Debian/Ubuntu we have libpulse-dev package (seems this package have all headers you needed), all others have similar.

P.S. I'm trying to package your software and upload it to official Debian repository.

@i-rinat
Copy link
Owner

i-rinat commented Oct 2, 2014

why you bundled pulseaudio headers instead of to require pulseaudio development files as build dependency.

Initially it was a build dependency. But it turned out that in some distributions to acquire headers, one needs to install whole PulseAudio package. Some of distros have version 4, which causes compilation to fail. To solve these issues, I just threw headers itself into repository.

If you want to use headers from libpulse-dev, comment that line out:

include_directories(3rdparty/pulseaudio-headers)

Make sure you have libpulse-dev in the Build-Depends line.

@tataranovich
Copy link
Author

Thank you for the explanation.

@i-rinat
Copy link
Owner

i-rinat commented Oct 2, 2014

175e0bf

try configuring with cmake -DUSE_BUNDLED_PULSEAUDIO_HEADERS=0 -DCMAKE_BUILD_TYPE=Release ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants