Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to fallback to key when trans string is empty #379

Merged
merged 1 commit into from
May 18, 2015
Merged

Allow to fallback to key when trans string is empty #379

merged 1 commit into from
May 18, 2015

Conversation

limdauto
Copy link
Contributor

I think it's sensible to display the key (sometimes people use English string or whichever default language they use as key) instead of an empty string.

@captolia
Copy link

+1

1 similar comment
@timseverien
Copy link

+1

@jamuhl
Copy link
Member

jamuhl commented Apr 20, 2015

if i accept this PR the other 50% will complain that they want empty string as an acceptable value (was like this before).

make that depending on a setting provide on init showKeyIfEmpty (like fallbackOnEmpty, fallbackOnNull)

@limdauto
Copy link
Contributor Author

@jamuhl cool. I will add that init option. Thanks for replying.

@limdauto
Copy link
Contributor Author

@jamuhl sorry for the delay. I have added the init option. Could you please take a look? Thnx

@jamuhl
Copy link
Member

jamuhl commented May 4, 2015

perfectm, thank you...will merge this asap.

jamuhl added a commit that referenced this pull request May 18, 2015
Allow to fallback to key when trans string is empty
@jamuhl jamuhl merged commit daa7539 into i18next:master May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants