withI18n breaks static members

[ghengeveld]

An example demonstrates this best:

import React from "react"
import { withI18n } from "react-i18next"

class Demo extends React.Component {
  static foo = "bar"
  render() {
    return <div />
  }
}

Demo.Member = () => <div />

console.log(Object.keys(Demo))             // => ["foo", "Member"]
console.log(Object.keys(withI18n()(Demo))) // => []

This essentially breaks access to static members of the wrapped component, which is often used to expose compound components.

I discovered this when using I18next with React Async, which uses compound components.

[ghengeveld]

What you probably need to do is hoist non-react statics: https://github.com/mridgway/hoist-non-react-statics

See also: https://reactjs.org/docs/higher-order-components.html#static-methods-must-be-copied-over

[jamuhl]

done for withNamespaces https://github.com/i18next/react-i18next/blob/master/src/withNamespaces.js#L56

feel free to provide a PR doing the same for withI18n

[ghengeveld]

I'm writing a PR. Hold on.

[ghengeveld]

Fixed it 👍