Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added wm_class property #218

Merged
merged 1 commit into from
Jan 15, 2019
Merged

added wm_class property #218

merged 1 commit into from
Jan 15, 2019

Conversation

ivanvig
Copy link
Contributor

@ivanvig ivanvig commented Jan 14, 2019

Right now i3lock has only a wm_name property but lacks of wm_class which is useful to, for example, set compton rules for i3lock's window.

@Airblader
Copy link
Member

Thanks for the PR! I'm definitely in favor of adding this, but I think we could do entirely without the new macros here as they just add a level of redirection when reading the code that we don't need. Could you remove them and just use string literals instead? Be carefull for the length of "i3lock\0i3lock\0" to use 2 * (strlen("i3lock") + 1).

Also, please squash the commits into a single commit (and force-push the branch) and drop a comment here so that we get notified. Thank you!

@ivanvig
Copy link
Contributor Author

ivanvig commented Jan 15, 2019

I think is done, went back to master and only added the code block corresponding to the property

@Airblader Airblader merged commit a395006 into i3:master Jan 15, 2019
@Airblader
Copy link
Member

Thank you!

@ivanvig ivanvig deleted the wm_class-patch branch January 16, 2019 00:06
sh1r4s3 pushed a commit to sh1r4s3/i3lock-gif that referenced this pull request Jun 26, 2022
* Clarify brace behaviour (i3#217)

* Add comment

Co-authored-by: Raymond Li <hi@raymond.li>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants