Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiRotor : (on landings and) after disarm the QUAD tilts over instead of cutting down the motors #8945

Closed
Pairan opened this issue Apr 3, 2023 · 51 comments

Comments

@Pairan
Copy link

Pairan commented Apr 3, 2023

Current Behavior

The 7" Quad is flashed with regular INAV 6 and since then has changed dramatically in behaviour after disarming as after landing properly. I looks like the quad doesnt figure that it has been disarmed and tries to compensate ( ... and overshoots).

Mostly it flips over and the props spin aggressively for 1-2secs ... and a such most likely kill the props.

I didn't tune the rates or such. The defaults for a 7" quad was applied and nothing more (but flight modes and adjustment options for in-flight and such).

Steps to Reproduce

  1. Launch the quad
  2. decide to land
  3. try to disarm near the ground
  4. hope that it goes well (this time)

Expected behavior

After disarm I would have expected to simply shut everything down and DO NOTHING more than this.

Suggested solution(s)

Simply shut down motors on DISARM as it used to be ...

Additional context

I had think I also had it with INAV6 RC2 but I took it as me beeing clumsy on landings -.- But as it now happened several times yesterday I thought of reporting back in. Can anybody confirm this behaviour ?

  • FC Board name and vendor: MAMBAH743_2022B from DIATONE
  • INAV version string: latest INAV 6 (084101a)
@breadoven
Copy link
Collaborator

What reason does it give for the disarm, Switch or Landing ? Do you let the quad actually settle on the ground for 1-2s before disarming or try and disarm the moment it touches the ground or slightly before even ?

@Pairan
Copy link
Author

Pairan commented Apr 3, 2023

I want to land- not to disarm at 1m alt and let it fall into the dirt. And even in that height it would Tipp over and not simply shut down.

Only way to land properly for now is to grab the quad and disarm. Everything else will risk to spoil the gear

i still assume that disarm should simply switch off everything- and not try to balance things out

@Jetrell
Copy link

Jetrell commented Apr 3, 2023

@Pairan Can you leave your Diff All settings? And what flight mode were you in when you disarmed.

Can you clarify, from both your posts.. I'm wasn't sure which one it is.. Disarming near the ground, or landing then disarming, which was causing the issue ?

try to disarm near the ground

I want to land- not to disarm at 1m alt

@Pairan
Copy link
Author

Pairan commented Apr 4, 2023

The effect is the SAME on both landing and disarming near ground or just disarming! The thing is that the disarm doesn't cut the motors immediately and then tries to balance the movement after that.
Hard to describe ... guess I'll make a video of it later today to make the effect clear

Diff coming up:

# version
# INAV/MAMBAH743_2022B 6.0.0 Mar 22 2023 / 10:11:50 (084101ac)
# GCC-10.2.1 20201103 (release)

# Mixer: motor mixer
mmix reset

mmix 0  1.000 -1.000  1.000 -1.000
mmix 1  1.000 -1.000 -1.000  1.000
mmix 2  1.000  1.000  1.000  1.000
mmix 3  1.000  1.000 -1.000 -1.000

# features
feature -TX_PROF_SEL
feature GPS
feature PWM_OUTPUT_ENABLE

# beeper
beeper -RUNTIME_CALIBRATION
beeper -ON_USB

# blackbox
blackbox -NAV_ACC
blackbox NAV_POS
blackbox NAV_PID
blackbox MAG
blackbox ACC
blackbox ATTI
blackbox RC_DATA
blackbox RC_COMMAND
blackbox MOTORS
blackbox -GYRO_RAW
blackbox -PEAKS_R
blackbox -PEAKS_P
blackbox -PEAKS_Y

# Receiver: Channel map
map ERTA

# Ports
serial 1 2 115200 115200 0 115200
serial 2 33554432 115200 115200 0 115200
serial 3 0 115200 115200 0 115200

# Modes [aux]
aux 0 0 0 1500 2100
aux 1 2 1 1475 2100
aux 2 11 1 1125 1250
aux 3 10 1 1375 1475
aux 4 42 2 1100 1325
aux 5 43 2 1325 1675
aux 6 44 2 1675 2100
aux 7 13 4 1800 2100
aux 8 26 0 1700 2100
aux 9 27 1 1400 1475
aux 10 47 6 1600 2100

# Adjustments [adjrange]
adjrange 0 0 5 1125 1275 14 3
adjrange 1 0 5 1275 1425 15 3
adjrange 2 0 5 1400 1550 16 3
adjrange 3 0 5 1575 1750 10 3
adjrange 4 0 5 1700 1875 11 3
adjrange 5 0 5 1850 2025 12 3

# OSD [osd_layout]
osd_layout 0 0 13 10 H
osd_layout 0 1 2 15 V
osd_layout 0 3 8 6 V
osd_layout 0 4 8 6 V
osd_layout 0 7 46 4 V
osd_layout 0 8 9 14 H
osd_layout 0 9 23 14 H
osd_layout 0 10 1 1 H
osd_layout 0 11 3 17 V
osd_layout 0 12 2 16 V
osd_layout 0 13 2 7 H
osd_layout 0 14 46 0 V
osd_layout 0 15 23 6 H
osd_layout 0 22 7 0 V
osd_layout 0 23 2 0 V
osd_layout 0 24 23 1 V
osd_layout 0 26 46 10 V
osd_layout 0 28 45 17 V
osd_layout 0 29 23 9 H
osd_layout 0 30 13 15 V
osd_layout 0 31 42 0 V
osd_layout 0 32 2 14 V
osd_layout 0 33 46 18 V
osd_layout 0 34 21 0 V
osd_layout 0 38 1 8 H
osd_layout 0 40 2 1 V
osd_layout 0 46 23 6 H
osd_layout 0 47 22 9 H
osd_layout 0 80 2 14 H
osd_layout 0 85 2 9 V
osd_layout 0 87 2 2 V
osd_layout 0 96 45 9 V
osd_layout 0 97 10 13 H
osd_layout 0 105 37 1 H
osd_layout 0 109 44 3 V
osd_layout 0 110 44 1 V
osd_layout 0 111 25 9 H
osd_layout 0 112 38 1 V
osd_layout 1 1 1 14 V
osd_layout 1 11 2 13 V
osd_layout 1 15 24 2 V
osd_layout 1 22 6 1 V
osd_layout 1 23 1 1 V
osd_layout 1 30 1 10 V
osd_layout 1 31 1 14 H
osd_layout 1 35 22 13 H
osd_layout 1 48 1 11 H
osd_layout 1 49 1 12 H
osd_layout 1 98 23 1 H
osd_layout 1 99 25 3 H
osd_layout 1 109 24 12 H
osd_layout 1 110 24 11 H
osd_layout 1 111 25 9 H
osd_layout 1 112 25 10 H
osd_layout 2 2 0 0 V
osd_layout 2 3 8 6 V
osd_layout 2 7 24 1 V
osd_layout 2 15 1 1 V
osd_layout 2 16 1 1 H
osd_layout 2 22 23 1 V
osd_layout 2 26 6 1 V
osd_layout 2 41 1 2 H
osd_layout 2 63 1 2 H
osd_layout 2 99 1 3 H
osd_layout 2 109 24 12 H
osd_layout 2 110 24 11 H
osd_layout 2 111 25 9 H
osd_layout 2 112 25 10 H
osd_layout 3 1 8 14 V
osd_layout 3 10 2 13 H
osd_layout 3 12 2 14 V
osd_layout 3 16 2 4 V
osd_layout 3 17 2 5 V
osd_layout 3 18 2 6 V
osd_layout 3 20 13 3 H
osd_layout 3 21 13 4 H
osd_layout 3 22 7 1 V
osd_layout 3 23 2 1 V
osd_layout 3 37 9 12 H
osd_layout 3 41 23 3 V
osd_layout 3 42 23 2 V
osd_layout 3 46 22 13 H
osd_layout 3 47 22 11 H
osd_layout 3 56 2 7 V
osd_layout 3 58 2 8 V
osd_layout 3 63 18 12 H
osd_layout 3 81 2 10 V
osd_layout 3 82 2 11 V
osd_layout 3 83 2 12 V
osd_layout 3 97 13 1 V
osd_layout 3 106 2 9 H
osd_layout 3 109 24 12 H
osd_layout 3 110 24 11 H
osd_layout 3 111 25 9 H
osd_layout 3 112 25 10 H

# master
set looptime = 500
set gyro_main_lpf_hz = 90
set gyro_main_lpf_type = PT1
set dynamic_gyro_notch_q = 250
set dynamic_gyro_notch_min_hz = 60
set dynamic_gyro_notch_mode = 3D
set setpoint_kalman_q = 200
set gyro_zero_x = 1
set gyro_zero_y = -4
set gyro_zero_z = 12
set ins_gravity_cmss =  981.126
set acc_hardware = ICM42605
set acczero_x = -4
set acczero_y = 4
set acczero_z = 30
set accgain_x = 4093
set accgain_y = 4092
set accgain_z = 4108
set align_mag = CW90FLIP
set mag_hardware = HMC5883
set magzero_x = 17
set magzero_y = -110
set magzero_z = 29
set maggain_x = 507
set maggain_y = 496
set maggain_z = 470
set baro_hardware = SPL06
set serialrx_provider = CRSF
set blackbox_rate_denom = 2
set motor_pwm_rate = 2000
set motor_pwm_protocol = DSHOT600
set failsafe_procedure = RTH
set current_meter_scale = 80
set current_meter_type = ESC
set model_preview_type = 3
set applied_defaults = 2
set gps_provider = UBLOX7
set gps_sbas_mode = EGNOS
set gps_ublox_use_galileo = ON
set airmode_type = THROTTLE_THRESHOLD
set inav_w_z_baro_p =  0.350
set nav_auto_speed = 833
set nav_rth_allow_landing = FS_ONLY
set nav_rth_alt_mode = AT_LEAST_LINEAR_DESCENT
set nav_rth_altitude = 6000
set nav_mc_bank_angle = 45
set osd_video_system = AVATAR
set osd_time_alarm = 16
set osd_alt_alarm = 600
set osd_crsf_lq_format = TYPE2
set i2c_speed = 800KHZ
set name = FR7
set stats = ON
set stats_total_time = 14926
set stats_total_dist = 149676
set stats_total_energy = 987519
set tz_offset = 120
set tz_automatic_dst = EU
set vtx_band = 4
set vtx_channel = 6
set vtx_power = 4
set vtx_low_power_disarm = UNTIL_FIRST_ARM
set dshot_beeper_enabled = OFF

# profile
profile 1

set mc_p_pitch = 44
set mc_i_pitch = 80
set mc_d_pitch = 28
set mc_i_roll = 61
set mc_d_roll = 26
set mc_p_yaw = 40
set mc_i_yaw = 80
set dterm_lpf_hz = 80
set dterm_lpf_type = PT3
set mc_iterm_relax = RPY
set d_boost_min =  0.800
set d_boost_max =  1.200
set antigravity_gain =  2.000
set antigravity_accelerator =  5.000
set smith_predictor_delay =  1.500
set tpa_rate = 20
set tpa_breakpoint = 1200
set rc_expo = 75
set rc_yaw_expo = 75
set roll_rate = 70
set pitch_rate = 70
set yaw_rate = 60

# battery_profile
battery_profile 1

set bat_cells = 6
set vbat_min_cell_voltage = 300
set vbat_warning_cell_voltage = 315
set battery_capacity = 4200
set throttle_idle =  5.000

@breadoven
Copy link
Collaborator

OK. The reason I asked if the quad reports disarming via Switch or Landing is to understand if you are disarming it via the switch as soon as the quad touches down or if the landing detection is disarming the quad, in which case the cause of the disarm would be given as Landing (there would though be at least a 2s delay after settling on the ground before Landing detection caused a disarm).

I've noticed my quad sometimes flips on disarming via landing detection. Doesn't always do it, but often enough to be irritating. I had a theory as to why this is happening and a possible fix but never got around to testing it. However if this problem is also happening with a normal switched disarm the issue is likely something different. What happens if you raise the throttle after arming to enable airmode, lower the throttle back down and then disarm ?

I notice you're also using an H743 board. That might possibly have something to do with it.

@Pairan
Copy link
Author

Pairan commented Apr 4, 2023

So far I didn't let INAV time to figure, if we might have landet (landing in Acro) as it uses to wind up and then flips. Will have to check that on some grassy place so it won't kill the props (in case).
Task: Landing by descending and finally lower the thrust : INAV should figure "we" have landed? right?

I land by descending and slowly balancing the ground effect until I disarm. Will try to raise throttle after disarm next time.

Perhaps I report in this evening

@breadoven
Copy link
Collaborator

breadoven commented Apr 4, 2023

What happens if you raise the throttle after arming to enable airmode, lower the throttle back down and then disarm ?

By this I mean start with the quad disarmed. Then arm, raise the throttle until airmode activates, then fully lower the throttle, then disarm. Do it on a flat surface ideally. Does it still flip ?

@Pairan
Copy link
Author

Pairan commented Apr 4, 2023

Nope ... I recorded several landings and it didn't flip these times. Sometimes it had a hard time to detect it had landed and winded up some motors BUT then I disarmed and it was okay. Did nine attempts and nothing bad happened.

Guess for now we can close the ticket as I can't get it to do what it did yesterday.

Anyways ... thanks for helping and educating me on this :)

@Pairan Pairan closed this as completed Apr 4, 2023
@Pairan
Copy link
Author

Pairan commented Apr 9, 2023

IMG_3727

there‘s still something going on- after Position hold and landing I disarmed and then the quad started to flip and tried to get home! I was 1m away- it didn’t stop although I had tried to disarm several times.

Two props melted due to the heat on the motor shaft, my hand got burned by one motor and I had to rip out the power lead while two motors spinned 100%
My left hand cam to close to a prop and for now it doesn’t hurt- just bleeding and feeling a bit odd.

Guys… perhaps I can pull a log from the h743 but for now I will get back to iNav 5 where disarm stops everything.

@Pairan Pairan reopened this Apr 9, 2023
@breadoven
Copy link
Collaborator

A log would be very useful. Almost sounds as if disarming caused it to Failsafe and RTH. In that case without a Kill switch set up it would be impossible to disarm. Log should confirm if this was the case.

@Pairan
Copy link
Author

Pairan commented Apr 10, 2023

Sounds reasonable- I will clean up the quad later and see, what I can pull off the memory then

@Pairan
Copy link
Author

Pairan commented Apr 10, 2023

That's what I pulled of the quad - perhaps it can give any clue

blackbox_log_2023-04-10_194606.TXT.zip

@breadoven
Copy link
Collaborator

breadoven commented Apr 10, 2023

Well according to the log, 12/12, you simply selected Failsafe mode and RTH mode at the same time since they're both activated by the same switch (as confirmed in the Diff posted above). So the quad tried to RTH because that's what is told to do .... according to the log. However, shortly after selecting Failsafe the log file doesn't seem to record correctly, a few broken records but mainly blank, so something appears a little odd where that is concerned. Not sure why Failsafe and RTH modes are on the same switch given Failsafe is set to RTH anyway. This makes no sense. This is the the second time I've seen this erroneous setup recently. Has it been recommended somewhere ?

And since the log continued to record something it appears it never disarmed. There was no disarm flag at the end of the log file either.

@Pairan
Copy link
Author

Pairan commented Apr 11, 2023

that's strange ... as I recall it I did pull POS HOLD and as it didn't manage to stay on the altitude (1.5m or such) it bumped into the ground. I raised Thrust to compensate but that didn't work out. Next it bumped into the ground again and then it started. DISARM didn't work ... which is not found in the logs.
BUT I didn't activate RTH/FAILSAFE at that point - meaningless. I simply wanted to disarm.

Either it's because auf the H743 or changes in INAV6 that gets me here.

Checked my config for the mode Failsafe and removed it! I can't recall where it went into my defaults but I've been setting things up for ages like that. The Source ONE with INAV and also this FR7 did act as desired so far!
Failsafe could have entered the settings due to nav_rth_allow_landing = FS_ONLY. I don't know if INAV decides to land by itself without FAILSAFE so I changed the setting to set nav_rth_allow_landing = ALWAYS

There is no ranting about INAV6 from my side. I got a bit scared as I got hurt but besides that it flew great. But I will add the kill switch to the modes from now on and hope to not end up in this anytime soon.

@breadoven
Copy link
Collaborator

I take it this didn't climb during the RTH because instead it flipped upside down when RTH started. This is how it appears from the log at least. Is this what happened ?

@Pairan
Copy link
Author

Pairan commented Apr 11, 2023

I would say that is what happened- ... one side of the quad gets more thrust and as such it flips ... then the "tries to climb" perhaps

@Jetrell
Copy link

Jetrell commented Apr 25, 2023

I had this happen today too.
I've never tried to disarm just above the ground when a quad was in the RTH landing phase.
But I did that today. And it disarmed, then flipped over to the right.

It sounded like the motors shut off on disarm. But the attitude control was still active.
I check that log file and it showed only a little after the disarm, but not the flip.. Because the flip over wasn't instantaneous. There was about a 0.2 second delay after the motors stopped on disarm, before the flip over occurred.

MAMBAF405_2022A
INAV 6.1

@Pairan
Copy link
Author

Pairan commented Apr 25, 2023

It sounded like the motors shut off on disarm. But the attitude control was still active.

That's how it felt the first time too ... motors shut down and then the quad wanted to counter the movement and throttled up again.
Glad you didn't get hurt and glad I'm not the only one in this!

@Jetrell
Copy link

Jetrell commented Apr 26, 2023

@breadoven @MrD-RC Concerning this issue and the SAVED SETTINGS after disarm.. Does this save reboot the FC ?
The reason I ask, is because I've noticed in 6.1, the ESC communication connection tune occurs after the FC is disarmed. Just like it does after the initial FC bootup.
And I was thinking that the flip over could be connected to the eeprom save and reboot while the MC is airborne. #8907

I also experienced the PinIO USER 1 power switcher, powered off the HD VTX after disarming... That's never happened before. But this too could be related to SAVE SETTINGS that is effecting CRSF or even the logic condition that drives the PinIO.
Luckily its only happened once so far, and on the ground. An accidental disarm in the air is scary to think about, with stuff like this occurring.

MATEK F722WPX
INAV 6.1RC1

@MrD-RC
Copy link
Collaborator

MrD-RC commented Apr 26, 2023

No, the save when your see settings saved does not reboot.

Its still doing what it did before. Only on the next loop, and only once. Not potential multiple saves.

@breadoven
Copy link
Collaborator

I did wonder if resetting the PID accumulators immediately before disarming would solve this tipping problem. Effectively kills airmode so less likely to have motor surges happening at the point the motors are shut off. Can't do any harm so worth trying if this is a common issue.

@Jetrell
Copy link

Jetrell commented Apr 27, 2023

I did wonder if resetting the PID accumulators immediately before disarming would solve this tipping problem.

To be honest. I'm seeing discrepancies that don't seem to indicate error accumulation.

In this landing the quad was disarmed 10cm above the ground in Angle mode.. Note the G shock as it touch down. There was no flip over.

Angle disarm just above the ground

While in this RTH_LANDING phase, the quad was disarmed about 20cm above the ground. Without Air mode enabled. (I never permanently enable it).
It stayed in navState RTH_LANDING after disarming.. And I had the goggle lifted watching this landing... It actually hit the ground with the motors stopped, before the left motors start up again and flip it over, then shut down.. The flip over was after the log stopped recording.. Pity the logger didn't keep recording for a few seconds after disarming.

RTH disarm

I'm seeing a lot of weird stuff lately, like i touched on in the earlier posts.. And I'm still trying to track down these issues.... Without them being consistently repeatable.. I'm thinking it may even be related to the CRSF's RF link to the FC.

e.g. today, I did a FS test, by turning off the radio. It flew most of the way back home.. Then I turned the TX back on.. I regained pitch, roll and yaw control. But the throttle got stuck a 47%. The logs showed the rcCommand[throttle] to be at that value, even though I'm 100% certain I had it pull low, to try to stop it climbing.
The RF link was recovered immediately, according to the OSD.. But the log showed it took 8 seconds for me to regain manual throttle control again.
Capture

@Jetrell
Copy link

Jetrell commented Apr 29, 2023

Part of the issue appears to be related to - set stats = ON... I noticed you have it enable too @Pairan

@MrD-RC and @breadoven If you guys get the chance at some point. Would you be able to have a look how this feature is tied into the Disarming process.
The function seems to effect both Multi Copter and Fixed wings, But the results are worse with MC's.
And its only seems to be an issue 1 time in 5.... Like its caused by a race condition in the scheduler at disarming.
The effect is worse with Dshot than PWM protocols.

@Pairan
Copy link
Author

Pairan commented Apr 29, 2023

Yeps, it’s activated. Both on fw and mr and since I use dshot the pattern matches for me

@Jetrell
Copy link

Jetrell commented May 13, 2023

@breadoven @Pairan Did either of you get a chance to confirm whether set stats = OFF would fix the disarm flip over / reboot issue in your cases?

@Pairan
Copy link
Author

Pairan commented May 13, 2023

Nope … after I removed the rth + failsafe combo it didn’t occur any more for me. Even installed a switch for the “kill switch mode”

yesterday I upped mine to v6.1

I didn’t have any flips so far. But that doesn’t guarantee they’re gone. Just nothing new on that from my side

@steviegeek
Copy link

I experienced exactly this issue today on a 7" quad. Are we any closer to a solution please ?
This was using CRSF and a H743 FC
ARM switch was OFF
All NAV modes were OFF
Throttle was low
craft inverted, props racing drilling hole in field :-) challenging to get the battery disconnected.

version

INAV/MATEKH743 6.0.0 Mar 22 2023 / 10:48:04 (084101a)

GCC-10.2.1 20201103 (release)

@oldrootbeer
Copy link

I can confirm this as I was present and it was a very dangerous situation. Disarm should mean disarm.

@Jetrell
Copy link

Jetrell commented Jun 25, 2023

@steviegeek @oldrootbeer Don't stay on 6.0.0 with any H743 controller.. There was a fix implemented in 6.1 to alleviate most of this problem with those controllers.

@oldrootbeer
Copy link

There was a fix implemented in 6.1 to alleviate most of this problem with those controllers.

Thank you. You say "most of this problem"? Is 6.1 safe wrt disarming?

@breadoven
Copy link
Collaborator

I experienced exactly this issue today on a 7" quad. Are we any closer to a solution please ? This was using CRSF and a H743 FC ARM switch was OFF All NAV modes were OFF Throttle was low craft inverted, props racing drilling hole in field :-) challenging to get the battery disconnected.

version

INAV/MATEKH743 6.0.0 Mar 22 2023 / 10:48:04 (084101a)

GCC-10.2.1 20201103 (release)

Would be useful if you could provide a Diff and a log would be useful also.

@Jetrell
Copy link

Jetrell commented Jun 26, 2023

You say "most of this problem"? Is 6.1 safe wrt disarming?

6.1.0 and 6.1.1 are safer options.. But there are still some combinations of user settings that can cause problems.
Like @breadoven said, providing a DIFF file of your settings may be useful to find any potential issues.

@steviegeek
Copy link

@Jetrell
@breadoven

I've attached the DIFF ALL file, unfortunately I do not have logs (sdcard corrupt/damaged)
Thank you for your interest in this problem, very much appreciated.

DIFF ALL 230626.txt

@steviegeek
Copy link

@Jetrell
@breadoven

Hi guys, will you have the chance to cast your eyes over this DIFF file?
all suggests are most welcome
Thank You
Steve

@Jetrell
Copy link

Jetrell commented Jun 28, 2023

@steviegeek At present, there are a couple of settings that I've found to cause a conflict and a possible disarming flip-over problem.. But in your case, neither are present.
So load 6.1.1... It should be fine.. But as always.. Use caution for the first couple of flights.

@steviegeek
Copy link

steviegeek commented Jun 29, 2023

@Jetrell
Thank You,
I'll do that update and test it, very carefully 🙂
Probably on Saturday morning at a club field for safety
Much appreciate your help 👍

@breadoven
Copy link
Collaborator

I assume you're not using ELRS ? It's just that you're arming channel is 7 (Aux 2) rather than the 5 that is required for ELRS. Not sure if this is true for Crossfire or not.

I'm guessing this is the same problem as above ... when you went to disarm or did something else Failsafe occurred which makes normal disarm impossible. Was there any indication of failsafe in the OSD ?

And I assume you've added the Killswitch mode since you had this problem ?

@steviegeek
Copy link

@breadoven
It's CRSF, channel 7 has been my standard arming channel on everything since I got CSFR 5-6 years ago
All CSFR channels are full resolution so no need for a dedicated arming channel like ELRS

FS shows in OSD almost two minutes after it has been inverted and trying to reach Australia
It landed in ANGLE + ALTHOLD, I turned of ALTHOLD but would still not shutdown motors.

A 'sanity mode' of 'high motors' + 'no altitude change' = 'shutdown' would at first thoughts seem to be a good idea but the actual criteria would need more detailed thought.

@breadoven
Copy link
Collaborator

Just to confirm:

  1. You landed in Angle + Althold ... then tried to disarm ? At this point it flipped and didn't disarm so you shut off Althold but this made no difference, motors continued to run ?
  2. FS was showing in the OSD for 2 mins after you tried to disarm and the quad flipped over or it only appeared 2 mins after you tried to disarm ?

@steviegeek
Copy link

You landed in Angle + Althold ... then tried to disarm ? At this point it flipped and didn't disarm so you shut off Althold but this made no difference, motors continued to run ?

Yes, tried to disarm as soon as it contacted the ground.

it only appeared 2 mins after you tried to disarm ?

Yes, OSD video available if it helps

@breadoven
Copy link
Collaborator

The OSD video would be useful thanks.

@steviegeek
Copy link

@Pairan
Copy link
Author

Pairan commented Jun 30, 2023

Yeah … that’s how mine went down too.

@breadoven
Copy link
Collaborator

Hmmm, looking at the video it does appear that this simply crashed into the ground and rolled over inverted (It "landed" with 20 mph ground speed after all). This wasn't a case of it flipping when disarmed after a normal vertical landing since it didn't disarm. If you did correctly disarm it then this would appear to be the only issue here. The Failsafe happened because the Rx signal was lost after a minute or so, so INAV worked as expected in this case unless there was no good reason for the signal dropping I guess (Tx turned off, broken Rx/antenna ?).

Exactly when in the video do you think you attempted to disarm the quad ... before the initial impact with the ground or after it ended up inverted ?

@Jetrell
Copy link

Jetrell commented Jun 30, 2023

This wasn't a case of it flipping when disarmed after a normal vertical landing since it didn't disarm.

I agree..
Not at all like I've experienced, as I posted here - #8945 (comment)

@steviegeek
Copy link

The part of this incident that caused me concern was that when it was inverted on the ground (however that happened) the motors continued to run and I was not able to shut them down.
Which brings me to ..
A 'sanity mode' of 'high motors' + 'no altitude change' = 'shutdown' would at first thoughts seem to be a good idea but the actual criteria would need more detailed thought.
Should (is there already) some code that covers this? if not then should we start a new request for it?

In addition to 'disarm' Ardupilot has a 'Motor Emergency Stop' which overides all else. Could INAV include something similiar please for safety reasons ?

Thank you

@breadoven
Copy link
Collaborator

INAV has Killswitch mode. You have it configured to use according to your Diff (Channel 13 ?). This should disarm in all circumstances including during Failsafe (when the normal disarm switch is inhibited).

However, the problem here is Failsafe was not active when you tried to disarm, you also had a valid RC signal according to the video so there's no reason why the normal Disarm switch shouldn't have worked. Given that the AltHold mode switch seemed to work it's hard to see why the Disarm switch also didn't work before the Failsafe kicked in. From the way INAV behaved it appears it never received the Disarm switch command although without a log it's hard to know. A Transmitter log might show the channel status if you have one ?

@steviegeek
Copy link

@breadoven
@Jetrell

Firstly thanks for confirming how the kill switch mode works, 'disarm in all circumstances'
I'd been struggling as the documentation indicates it modifies how the disarm switch works but was not really definitive.
But I must ask, does 'in all circumstances' really mean total motor shutdown always?

I intend to run more tests tomorrow, with blackbox logging.

  • land in POSHOLD
  • land in ALTHOLD
  • land in ANGLE
  • hover in POSHOLD a few feet high, disarm switch should not have any effect (nav_overrides_motor_stop = ALL_NAV), kill switch should drop it to the ground (set disarm_kill_switch = ON)

I'm sorry that I do not have a clearer picture of exactly what happened.
I appreciate all your help and hope that with 6.1.1 and greater skill on my part all this can be left behind.

Thanks again
Steve

@oldrootbeer
Copy link

A sanity check is preferable in any rc link lost situation I guess. Regardless of any failsafe mode. Who knows what the craft is doing, where it is and how dangerous it is behaving.

@breadoven
Copy link
Collaborator

disarm_kill_switch just determines if the normal disarm switch disarms regardless of throttle position (when set to ON, the default) or only if the throttle is low (set to OFF). So you don't want to try to disarm in Poshold 2 feet above the ground because it will just disarm and drop. Killswitch mode on the other hand will disarm always regardless of other settings or Failsafe being active. disarm_kill_switch and Killswitch mode are probably a bit confusing because although they are related to disarming they are fundamentally different things.

nav_overrides_motor_stop has nothing to do with disarming, it just affects whether the motor stops or not when the throttle stick is low during Nav modes using Auto throttle.

@b14ckyy
Copy link
Collaborator

b14ckyy commented Mar 21, 2024

Should not be an issue anymore in 7.1 after #9681
Please test and if this is still an issue, we can reopen.

@b14ckyy b14ckyy closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants