Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add odometer to OSD #9335

Merged
merged 7 commits into from Oct 7, 2023
Merged

Add odometer to OSD #9335

merged 7 commits into from Oct 7, 2023

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Oct 1, 2023

Fixes #8980

Adds the ability to show the total flight distance odometer in the OSD. This needs stats enabled to work.

image
Odometer shown lower left of OSD.

Requires configurator: iNavFlight/inav-configurator#1836

Updated for new osdFormatCentiNumber declaration.
@MrD-RC MrD-RC merged commit ff6a4bc into master Oct 7, 2023
14 checks passed
@MrD-RC MrD-RC deleted the MrD_Add-odometer-to-OSD branch October 7, 2023 09:11
@rts18
Copy link

rts18 commented Oct 31, 2023

@MrD-RC
If STATS = ON.
When the craft is disarmed any ESC using Dshot protocol will reboot.

@breadoven This causes grief with multirotor inflight emergency rearming. #9254
Tested with two F405 flight controllers.

Someone else has reported this matter. Now it has come to a head, with bad results.
#8945 (comment)

@Jetrell I guess you never discovered this problem when testing. Maybe because you've never used the stats again. Wise move!!

@DzikuVx If this matter can not be resolved before the 7.0.0 release. May I ask that the release notes make mention of it ?

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Oct 31, 2023

@rts18 this should really be it’s own issue for visibility.

@Jetrell
Copy link

Jetrell commented Oct 31, 2023

I guess you never discovered this problem when testing. Maybe because you've never used the stats again. Wise move!!

I haven't used Stats on any of my models since I wrote that post... I'd actually forgotten about it when I was testing inflight rearming.. But I wouldn't have enable it, to prove what I already knew.

I'm sorry if it caused a crash.. Sometimes things slip through the cracks.

@breadoven
Copy link
Collaborator

@rts18 what do you mean by grief where emergency in flight rearming is concerned, other than the fact it obviously won't work if the FC reboots ?

@rts18
Copy link

rts18 commented Oct 31, 2023

this should really be it’s own issue for visibility.

I was hoping to get some clarity here first. Of why this matter seemed to have been over looked.

But I wouldn't have enable it, to prove what I already knew.

Fair enough.

other than the fact it obviously won't work if the FC reboots ?

It wasn't caused by the inflight rearming software. And it wasn't the flight controller that rebooted after disarming. It was the 4 ESCs.
This obviously takes between 2 to 4 seconds for them to play their tune in the reboot sequence. With some reinitializing faster than others.
That in turn sent the quad into a spinning tumble. With great similarity to issue 8945.

For what its worth. I did test the inflight rearming on this quad before I stupidly trusted turning on the stats. And it worked with no hitches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to show 'stats_total_dist' in the OSD
4 participants